You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by jg...@apache.org on 2018/09/18 08:40:40 UTC

tomee git commit: PMD/Checkstyle

Repository: tomee
Updated Branches:
  refs/heads/tomee-1.7.x 702264588 -> d7f07fa27


PMD/Checkstyle


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/d7f07fa2
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/d7f07fa2
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/d7f07fa2

Branch: refs/heads/tomee-1.7.x
Commit: d7f07fa27d0344a830ca5b838ff3f1947789f645
Parents: 7022645
Author: Jonathan Gallimore <jo...@jrg.me.uk>
Authored: Tue Sep 18 09:39:56 2018 +0100
Committer: Jonathan Gallimore <jo...@jrg.me.uk>
Committed: Tue Sep 18 09:39:56 2018 +0100

----------------------------------------------------------------------
 .../java/org/apache/openejb/assembler/classic/Assembler.java   | 4 ++--
 .../apache/openejb/monitoring/ConnectionFactoryMonitor.java    | 2 +-
 .../java/org/apache/openejb/monitoring/MBeanPojoWrapper.java   | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tomee/blob/d7f07fa2/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
index e1cd38c..862abae 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
@@ -1926,7 +1926,7 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
         removeResourceInfo(name);
     }
 
-    private void removeResourceMBean(String name, String type) {
+    private void removeResourceMBean(final String name, final String type) {
         final ObjectNameBuilder jmxName = new ObjectNameBuilder("openejb.management");
         jmxName.set("J2EEServer", "openejb");
         jmxName.set("J2EEApplication", null);
@@ -3088,7 +3088,7 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
         return service;
     }
 
-    private void registerAsMBean(final String name, final String type, Object resource) {
+    private void registerAsMBean(final String name, final String type, final Object resource) {
         final MBeanServer server = LocalMBeanServer.get();
 
         final ObjectNameBuilder jmxName = new ObjectNameBuilder("openejb.management");

http://git-wip-us.apache.org/repos/asf/tomee/blob/d7f07fa2/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ConnectionFactoryMonitor.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ConnectionFactoryMonitor.java b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ConnectionFactoryMonitor.java
index 3dad61f..52b6d8f 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ConnectionFactoryMonitor.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/ConnectionFactoryMonitor.java
@@ -154,7 +154,7 @@ public class ConnectionFactoryMonitor {
 
         private final String name;
 
-        PartitionStrategy(String name) {
+        PartitionStrategy(final String name) {
             this.name = name;
         }
 

http://git-wip-us.apache.org/repos/asf/tomee/blob/d7f07fa2/container/openejb-core/src/main/java/org/apache/openejb/monitoring/MBeanPojoWrapper.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/MBeanPojoWrapper.java b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/MBeanPojoWrapper.java
index 85aa872..e92bc35 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/MBeanPojoWrapper.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/MBeanPojoWrapper.java
@@ -69,7 +69,7 @@ public class MBeanPojoWrapper implements DynamicMBean {
         scan(delegate.getClass());
     }
 
-    private void scan(Class clazz) {
+    private void scan(final Class clazz) {
         final List<MBeanAttributeInfo> mBeanAttributeInfoList = new ArrayList<MBeanAttributeInfo>();
 
         try {
@@ -79,7 +79,7 @@ public class MBeanPojoWrapper implements DynamicMBean {
 
             for (final PropertyDescriptor propertyDescriptor : propertyDescriptors) {
                 final String propertyName = propertyDescriptor.getName();
-                Class<?> propertyType = propertyDescriptor.getPropertyType();
+                final Class<?> propertyType = propertyDescriptor.getPropertyType();
 
                 if (! isSupported(propertyType)) {
                     continue;
@@ -105,7 +105,7 @@ public class MBeanPojoWrapper implements DynamicMBean {
                 new MBeanNotificationInfo[0]);
     }
 
-    private static boolean isSupported(Class<?> type) {
+    private static boolean isSupported(final Class<?> type) {
         return SUPPORTED_PROPERTY_TYPES.contains(type);
     }