You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/02/14 07:36:05 UTC
[GitHub] [ratis] guohao-rosicky opened a new pull request #600: RATIS-1522. OrderedStreamAsync uses a separate of send thread pool
guohao-rosicky opened a new pull request #600:
URL: https://github.com/apache/ratis/pull/600
## What changes were proposed in this pull request?
OrderedStreamAsync uses a separate of send thread pool
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] guohao-rosicky commented on pull request #600: RATIS-1522. OrderedStreamAsync uses a separate of send thread pool
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #600:
URL: https://github.com/apache/ratis/pull/600#issuecomment-1038921724
@szetszwo Yes, I don't have specific test data yet, I run it in my internal version for a while, and update later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on a change in pull request #600: RATIS-1522. OrderedStreamAsync uses a separate of send thread pool
Posted by GitBox <gi...@apache.org>.
szetszwo commented on a change in pull request #600:
URL: https://github.com/apache/ratis/pull/600#discussion_r805583087
##########
File path: ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedStreamAsync.java
##########
@@ -147,16 +153,16 @@ private void sendRequestToNetwork(DataStreamWindowRequest request,
scheduleWithTimeout(request);
- requestFuture.thenApply(reply -> {
+ requestFuture.thenApplyAsync(reply -> {
Review comment:
This is only for processing the reply which is simple memory operations without any IO. Are you sure this would help the performance?
Since we are using Netty, there is already a EventLoopGroup in Netty to do the send IO; see https://github.com/apache/ratis/blob/d41d0930c49c4cfcd8cd709519329e22fbbe61b4/ratis-netty/src/main/java/org/apache/ratis/netty/client/NettyClientStreamRpc.java#L247-L259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #600: RATIS-1522. OrderedStreamAsync uses a separate of send thread pool
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #600:
URL: https://github.com/apache/ratis/pull/600#issuecomment-1051608483
@guohao-rosicky , thanks for testing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] guohao-rosicky commented on pull request #600: RATIS-1522. OrderedStreamAsync uses a separate of send thread pool
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #600:
URL: https://github.com/apache/ratis/pull/600#issuecomment-1051447835
@szetszwo I close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] guohao-rosicky commented on pull request #600: RATIS-1522. OrderedStreamAsync uses a separate of send thread pool
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #600:
URL: https://github.com/apache/ratis/pull/600#issuecomment-1051447136
After a period of testing, no significant performance improvement was found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] guohao-rosicky closed pull request #600: RATIS-1522. OrderedStreamAsync uses a separate of send thread pool
Posted by GitBox <gi...@apache.org>.
guohao-rosicky closed pull request #600:
URL: https://github.com/apache/ratis/pull/600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] guohao-rosicky commented on pull request #600: RATIS-1522. OrderedStreamAsync uses a separate of send thread pool
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #600:
URL: https://github.com/apache/ratis/pull/600#issuecomment-1038751298
@szetszwo What do you think of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org