You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by jc...@apache.org on 2017/06/29 18:06:49 UTC
svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS
Author: jchampion
Date: Thu Jun 29 18:06:49 2017
New Revision: 1800307
URL: http://svn.apache.org/viewvc?rev=1800307&view=rev
Log:
Propose showstopper.
Modified:
httpd/httpd/branches/2.4.x/STATUS
Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1800307&r1=1800306&r2=1800307&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Thu Jun 29 18:06:49 2017
@@ -112,6 +112,12 @@ CURRENT RELEASE NOTES:
RELEASE SHOWSTOPPERS:
+ *) PR61202: remove FPM-specific logic from mod_proxy_fcgi. Returns us to
+ 2.4.20 FCGI behavior by default.
+ trunk patch: https://svn.apache.org/r1800306
+ 2.4.x patch: trunk works, modulo APLOGNO and CHANGES
+ +1: jchampion
+
PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
[ start all new proposals below, under PATCHES PROPOSED. ]
Re: FastCGI env-vars
Posted by Jacob Champion <ch...@gmail.com>.
On 07/02/2017 08:44 AM, William A Rowe Jr wrote:
> I'm reading https://tools.ietf.org/html/rfc3875#section-4.1.5 as the
> PATH_INFO is entirely distinct from QUERY_STRING.
Right. SCRIPT_NAME, PATH_INFO, and QUERY_STRING are intended to be three
distinct parts of the Script-URI (see Section 3.3). I.e. you should be
able to percent-encode and concatenate them (with the correct
delimiters) to get an equivalent URI.
--Jacob
Re: FastCGI env-vars
Posted by William A Rowe Jr <wr...@rowe-clan.net>.
I'm reading https://tools.ietf.org/html/rfc3875#section-4.1.5 as the
PATH_INFO is entirely distinct from QUERY_STRING.
On Sun, Jul 2, 2017 at 10:08 AM, Jim Jagielski <ji...@jagunet.com> wrote:
> There is one (I hope!) final question... There seems to be
> conflicting interpretations on whether PATH_INFO should, or
> should NOT, include any QUERY_STRING info or "extra stuff"
> after the actual path itself...
>
> Right now, we don't.
Re: FastCGI env-vars
Posted by Jim Jagielski <ji...@jaguNET.com>.
There is one (I hope!) final question... There seems to be
conflicting interpretations on whether PATH_INFO should, or
should NOT, include any QUERY_STRING info or "extra stuff"
after the actual path itself...
Right now, we don't.
Re: FastCGI env-vars
Posted by Jacob Champion <ch...@gmail.com>.
On 06/30/2017 09:43 AM, Jim Jagielski wrote:
> In any case, I think HEAD of the perl test framework is finally in
> shape to test and catch expectations regarding how we
> handle FCGI env-vars, both in "generic" situations as well
> as how php-fpm sees/expects them. At least, the current
> rev "passes" all tests based on my assumptions on what
> those expected values should be (based on my reading of
> the RFCs and the examples given in the various PRs)...
Thanks for all your work on the framework! The new FPM tests look good
to me, and they pass with both 2.4.20 and trunk, which is a good sign.
--Jacob
FastCGI env-vars
Posted by Jim Jagielski <ji...@jaguNET.com>.
In any case, I think HEAD of the perl test framework is finally in
shape to test and catch expectations regarding how we
handle FCGI env-vars, both in "generic" situations as well
as how php-fpm sees/expects them. At least, the current
rev "passes" all tests based on my assumptions on what
those expected values should be (based on my reading of
the RFCs and the examples given in the various PRs)...
Currently we test FastCGI as implemented in Perl, php-fpm
using Location and Action/Handler, and php-fpm with "standard"
ProxyPass.
We have room for corrections and/or more tests :)
Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Jim Jagielski <ji...@jaguNET.com>.
> On Jun 30, 2017, at 11:43 AM, Eric Covener <co...@gmail.com> wrote:
>
> On Fri, Jun 30, 2017 at 11:10 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote:
>> Thousands of bugs pass through STATUS, what makes yours special?
>
> It fixes a regression in the last release, I think it's close enough
> in spirit as a showstopper.
+1. (imo)
Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Eric Covener <co...@gmail.com>.
On Fri, Jun 30, 2017 at 11:10 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote:
> Thousands of bugs pass through STATUS, what makes yours special?
It fixes a regression in the last release, I think it's close enough
in spirit as a showstopper.
Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Luca Toscano <to...@gmail.com>.
2017-06-30 17:34 GMT+02:00 Jacob Champion <ch...@gmail.com>:
> On 06/30/2017 08:10 AM, William A Rowe Jr wrote:
>
>> -1 on showstopper. It's a bug, no security implications, cope with it.
>>
>> Thousands of bugs pass through STATUS, what makes yours special?
>>
>
> It's a reinstatement of my previous 2.4.26 showstopper, which got no
> objections, was unaddressed by the proposed patch for it, and is finally
> addressed with this patch.
>
> We've busted people three releases in a row, and we already have emails on
> the list asking if we're going to fix it next release, or if those affected
> need to hardwire workarounds into their stacks, which is exactly what we
> don't want. My showstopper stands unless more PMC members object, in which
> case I will retract it.
+1 to Jacob's point.
Luca
Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Jacob Champion <ch...@gmail.com>.
On 06/30/2017 08:10 AM, William A Rowe Jr wrote:
> -1 on showstopper. It's a bug, no security implications, cope with it.
>
> Thousands of bugs pass through STATUS, what makes yours special?
It's a reinstatement of my previous 2.4.26 showstopper, which got no
objections, was unaddressed by the proposed patch for it, and is finally
addressed with this patch.
We've busted people three releases in a row, and we already have emails
on the list asking if we're going to fix it next release, or if those
affected need to hardwire workarounds into their stacks, which is
exactly what we don't want. My showstopper stands unless more PMC
members object, in which case I will retract it.
--Jacob
Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS
Posted by William A Rowe Jr <wr...@rowe-clan.net>.
-1 on showstopper. It's a bug, no security implications, cope with it.
Thousands of bugs pass through STATUS, what makes yours special?
That said, unconditional +1 to any mod_proxy_fcgi.c patches you or Jim or
any committers determine for backport, I'd prefer we treat the module as
experimental until it behaves how we desire and in any way compatible with
PHP's tomfoolery.
On Jun 29, 2017 1:06 PM, <jc...@apache.org> wrote:
> Author: jchampion
> Date: Thu Jun 29 18:06:49 2017
> New Revision: 1800307
>
> URL: http://svn.apache.org/viewvc?rev=1800307&view=rev
> Log:
> Propose showstopper.
>
> Modified:
> httpd/httpd/branches/2.4.x/STATUS
>
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/
> STATUS?rev=1800307&r1=1800306&r2=1800307&view=diff
> ============================================================
> ==================
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Thu Jun 29 18:06:49 2017
> @@ -112,6 +112,12 @@ CURRENT RELEASE NOTES:
>
> RELEASE SHOWSTOPPERS:
>
> + *) PR61202: remove FPM-specific logic from mod_proxy_fcgi. Returns us to
> + 2.4.20 FCGI behavior by default.
> + trunk patch: https://svn.apache.org/r1800306
> + 2.4.x patch: trunk works, modulo APLOGNO and CHANGES
> + +1: jchampion
> +
>
> PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
> [ start all new proposals below, under PATCHES PROPOSED. ]
>
>
>