You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by jtstorck <gi...@git.apache.org> on 2016/05/16 21:20:46 UTC

[GitHub] nifi pull request: NIFI-1881 Added surefire-junit4 dependency to t...

GitHub user jtstorck opened a pull request:

    https://github.com/apache/nifi/pull/449

    NIFI-1881 Added surefire-junit4 dependency to the surefire build plug

    \u2026in configuration to force Surefire to run tests with JUnit.  This specifically addresses the issue as it relates to version 0.x.  For 1.0.0, the PR for NIFI-1799 includes this same POM update.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jtstorck/nifi NIFI-1881

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #449
    
----
commit 2cc0c1ba02a3e1150c8ad3731325758f963ddb88
Author: Jeff Storck <jt...@gmail.com>
Date:   2016-05-16T21:10:37Z

    NIFI-1881 Added surefire-junit4 dependency to the surefire build plugin configuration to force Surefire to run tests with JUnit.  This specifically addresses the issue as it relates to version 0.x.  For 1.0.0, the PR for NIFI-1799 includes this same POM update.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1881 Added surefire-junit4 dependency to t...

Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck closed the pull request at:

    https://github.com/apache/nifi/pull/449


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1881 Added surefire-junit4 dependency to t...

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the pull request:

    https://github.com/apache/nifi/pull/449#issuecomment-219586093
  
    @jtstorck because I did not merge this into the `master` branch, the phrase `This closes #449.` in the commit message will not close this PR. Can you please manually close the PR? Thanks. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1881 Added surefire-junit4 dependency to t...

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the pull request:

    https://github.com/apache/nifi/pull/449#issuecomment-219556910
  
    Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1881 Added surefire-junit4 dependency to t...

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the pull request:

    https://github.com/apache/nifi/pull/449#issuecomment-219563962
  
    @jtstorck now when the build is run, full test output is provided as follows:
    
    ```
    [INFO] --- maven-surefire-plugin:2.18:test (default-test) @ nifi-framework-core ---
    [INFO] Surefire report directory: /Users/alopresto/Workspace/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/target/surefire-reports
    [INFO] Using configured provider org.apache.maven.surefire.junit4.JUnit4Provider
    
    -------------------------------------------------------
     T E S T S
    -------------------------------------------------------
    Running org.apache.nifi.cluster.HeartbeatPayloadTest
    Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.312 sec - in org.apache.nifi.cluster.HeartbeatPayloadTest
    Running org.apache.nifi.controller.repository.io.TestLimitedInputStream
    Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.apache.nifi.controller.repository.io.TestLimitedInputStream
    Running org.apache.nifi.controller.repository.TestFileSystemRepository
    Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.647 sec - in org.apache.nifi.controller.repository.TestFileSystemRepository
    Running org.apache.nifi.controller.repository.TestRingBufferEventRepository
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.267 sec - in org.apache.nifi.controller.repository.TestRingBufferEventRepository
    Running org.apache.nifi.controller.repository.TestStandardProcessSession
    Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.626 sec - in org.apache.nifi.controller.repository.TestStandardProcessSession
    Running org.apache.nifi.controller.repository.TestStandardProvenanceReporter
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.001 sec - in org.apache.nifi.controller.repository.TestStandardProvenanceReporter
    Running org.apache.nifi.controller.repository.TestVolatileContentRepository
    Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.681 sec - in org.apache.nifi.controller.repository.TestVolatileContentRepository
    Running org.apache.nifi.controller.repository.TestWriteAheadFlowFileRepository
    Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec - in org.apache.nifi.controller.repository.TestWriteAheadFlowFileRepository
    Running org.apache.nifi.controller.scheduling.TestProcessorLifecycle
    Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.427 sec - in org.apache.nifi.controller.scheduling.TestProcessorLifecycle
    Running org.apache.nifi.controller.scheduling.TestStandardProcessScheduler
    Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 38.235 sec - in org.apache.nifi.controller.scheduling.TestStandardProcessScheduler
    Running org.apache.nifi.controller.service.StandardControllerServiceProviderTest
    Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.102 sec - in org.apache.nifi.controller.service.StandardControllerServiceProviderTest
    Running org.apache.nifi.controller.service.TestStandardControllerServiceProvider
    Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.426 sec - in org.apache.nifi.controller.service.TestStandardControllerServiceProvider
    Running org.apache.nifi.controller.StandardFlowServiceTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.049 sec - in org.apache.nifi.controller.StandardFlowServiceTest
    Running org.apache.nifi.controller.state.providers.local.TestWriteAheadLocalStateProvider
    Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.981 sec - in org.apache.nifi.controller.state.providers.local.TestWriteAheadLocalStateProvider
    Running org.apache.nifi.controller.state.providers.zookeeper.TestZooKeeperStateProvider
    Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.482 sec - in org.apache.nifi.controller.state.providers.zookeeper.TestZooKeeperStateProvider
    Running org.apache.nifi.controller.state.TestStateMapSerDe
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in org.apache.nifi.controller.state.TestStateMapSerDe
    Running org.apache.nifi.controller.tasks.TestContinuallyRunProcessorTask
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.apache.nifi.controller.tasks.TestContinuallyRunProcessorTask
    Running org.apache.nifi.controller.TestFileSystemSwapManager
    Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.254 sec - in org.apache.nifi.controller.TestFileSystemSwapManager
    Running org.apache.nifi.controller.TestStandardFlowFileQueue
    Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.111 sec - in org.apache.nifi.controller.TestStandardFlowFileQueue
    Running org.apache.nifi.events.TestNodeBulletinProcessingStrategy
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.apache.nifi.events.TestNodeBulletinProcessingStrategy
    Running org.apache.nifi.fingerprint.FingerprintFactoryTest
    Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.094 sec - in org.apache.nifi.fingerprint.FingerprintFactoryTest
    Running org.apache.nifi.processor.TestSimpleProcessLogger
    Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec - in org.apache.nifi.processor.TestSimpleProcessLogger
    Running org.apache.nifi.processor.TestStandardPropertyValue
    Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.06 sec - in org.apache.nifi.processor.TestStandardPropertyValue
    Running org.apache.nifi.remote.RemoteProcessGroupStatusTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.071 sec - in org.apache.nifi.remote.RemoteProcessGroupStatusTest
    Running org.apache.nifi.util.ReflectionUtilsTest
    Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.03 sec - in org.apache.nifi.util.ReflectionUtilsTest
    
    Results :
    
    
    
    
    Tests run: 174, Failures: 0, Errors: 0, Skipped: 2
    ```
    
    Thanks for fixing this. Merging the PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1881 Added surefire-junit4 dependency to t...

Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on the pull request:

    https://github.com/apache/nifi/pull/449#issuecomment-219592267
  
    Closed PR at the request of @alopresto.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---