You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/17 08:20:51 UTC
[GitHub] [flink] liuyongvs opened a new pull request, #19746: [FLINK-27630][table-planner] Add maven-source-plugin for table planne…
liuyongvs opened a new pull request, #19746:
URL: https://github.com/apache/flink/pull/19746
…r values connector in test.
## Brief change log
- add test source jar to reponsitory when user use this values connector in flink-table-planner just like kafka/pulsar connector. So user can find the values source code.
- and we just need upload the */factories/* because it will be too large to upload all the flink-table-planner test source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #19746: [FLINK-27630][table-planner] Add maven-source-plugin for table planne…
Posted by GitBox <gi...@apache.org>.
wuchong merged PR #19746:
URL: https://github.com/apache/flink/pull/19746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a diff in pull request #19746: [FLINK-27630][table-planner] Add maven-source-plugin for table planne…
Posted by GitBox <gi...@apache.org>.
wuchong commented on code in PR #19746:
URL: https://github.com/apache/flink/pull/19746#discussion_r886484091
##########
flink-table/flink-table-planner/pom.xml:
##########
@@ -427,6 +427,30 @@ under the License.
</execution>
</executions>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-source-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-test-sources</id>
+ <goals>
+ <goal>test-jar-no-fork</goal>
+ </goals>
+ <configuration>
+ <archive>
+ <!-- Globally exclude maven metadata, because it may accidentally bundle files we don't intend to -->
+ <addMavenDescriptor>false</addMavenDescriptor>
+ </archive>
+ <includes>
+ <include>**/factories/**</include>
Review Comment:
Could you add a comment why introducing this plugin and why only include factories sources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19746: [FLINK-27630][table-planner] Add maven-source-plugin for table planne…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19746:
URL: https://github.com/apache/flink/pull/19746#issuecomment-1128569294
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d43c958b31c17f049c8d20052fcc84a388e484b3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d43c958b31c17f049c8d20052fcc84a388e484b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d43c958b31c17f049c8d20052fcc84a388e484b3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liuyongvs commented on pull request #19746: [FLINK-27630][table-planner] Add maven-source-plugin for table planne…
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on PR #19746:
URL: https://github.com/apache/flink/pull/19746#issuecomment-1130999976
hi @wuchong , ci passed, could you please review it ,thanks so much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liuyongvs commented on a diff in pull request #19746: [FLINK-27630][table-planner] Add maven-source-plugin for table planne…
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on code in PR #19746:
URL: https://github.com/apache/flink/pull/19746#discussion_r886528108
##########
flink-table/flink-table-planner/pom.xml:
##########
@@ -427,6 +427,30 @@ under the License.
</execution>
</executions>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-source-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-test-sources</id>
+ <goals>
+ <goal>test-jar-no-fork</goal>
+ </goals>
+ <configuration>
+ <archive>
+ <!-- Globally exclude maven metadata, because it may accidentally bundle files we don't intend to -->
+ <addMavenDescriptor>false</addMavenDescriptor>
+ </archive>
+ <includes>
+ <include>**/factories/**</include>
Review Comment:
added @wuchong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org