You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/12/01 14:23:10 UTC
Re: Review Request 39986: [2/5] Enabled the Authorizer to handle
Reserve/Unreserve ACLs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review108492
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Nov. 30, 2015, 8:33 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 8:33 p.m.)
>
>
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
>
>
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp c228c2b40ff5fdb007153101938f91ff269370a5
> src/authorizer/local/authorizer.hpp bc3e4e12a35f222783159e35c4662e182ba0c107
> src/authorizer/local/authorizer.cpp 853678b8fd3151d02fc77d5eadaf9948f33caebb
> src/tests/authorization_tests.cpp 32bcac731a6e8f8adb7298ed6c7174f6eb0499cb
> src/tests/mesos.hpp f097c683fed02240e9f54ac4491ab007f4652736
> src/tests/mesos.cpp a75182ec7f6d0c6063bbb36a6ccf4e8a4a81c8dd
>
> Diff: https://reviews.apache.org/r/39986/diff/
>
>
> Testing
> -------
>
> The is the second in a chain of 5 patches. This diff includes new tests for the authorization of reserve and unreserve operations via ACLs. `make check` was used to test after all patches were applied.
>
>
> Thanks,
>
> Greg Mann
>
>