You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jlprat (via GitHub)" <gi...@apache.org> on 2023/06/07 14:03:42 UTC
[GitHub] [kafka] jlprat opened a new pull request, #13824: MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde
jlprat opened a new pull request, #13824:
URL: https://github.com/apache/kafka/pull/13824
RemoteLogMetadataSerde references RemoteLogMetadataTransform in a Raw form. Given that the class is parametrized we should make use of it.
After fighting the Java type system and its type inference (or lack of thereof), this is the nicest way I could find to have 0 warnings while at the same time getting all what Java typing has to offer.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat merged PR #13824:
URL: https://github.com/apache/kafka/pull/13824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #13824: MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-1594214535
Hi @satishd or @showuon any opinions on this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-2063587938
Thanks @mimaison. Will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #13824: MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-1580955725
To improve this solution we would need to parametrize `RemoteLogMetadataSerde` only for the purpose of getting rid of the casting. Parametrizing the class would not bring any further benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-2063483812
@mimaison Rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #13824: MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-1580894961
Although its not perfect, it definitely improves on the current situation where we are just passing around raw usages of object references.
Looks good from my end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13824: MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-1720434714
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #13824: MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-1581463300
Tests failures seem all unrelated and I created the corresponding Jira tickets for the ones I couldn't fine an already existing one:
https://issues.apache.org/jira/browse/KAFKA-15070, https://issues.apache.org/jira/browse/KAFKA-15071 and https://issues.apache.org/jira/browse/KAFKA-15072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-2065886831
All tests failing for this build were known flaky tests. Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-2063586815
Feel free to merge once CI completes. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-2063460572
@jlprat Can you rebase to resolve the conflict? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org