You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/11 01:04:19 UTC

[GitHub] codecov-io edited a comment on issue #6497: pass source to db api mutator

codecov-io edited a comment on issue #6497: pass source to db api mutator
URL: https://github.com/apache/incubator-superset/pull/6497#issuecomment-446042066
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6497?src=pr&el=h1) Report
   > Merging [#6497](https://codecov.io/gh/apache/incubator-superset/pull/6497?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a2ce9974cd89c56224bc7b99cc6c667ecf23c4e6?src=pr&el=desc) will **increase** coverage by `17.25%`.
   > The diff coverage is `60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6497/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6497?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #6497       +/-   ##
   ==========================================
   + Coverage   56.24%   73.5%   +17.25%     
   ==========================================
     Files         518      74      -444     
     Lines       23007   10065    -12942     
     Branches     2750       0     -2750     
   ==========================================
   - Hits        12941    7398     -5543     
   + Misses       9655    2667     -6988     
   + Partials      411       0      -411
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6497?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `76.63% <ø> (ø)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.44% <100%> (+0.02%)` | :arrow_up: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.7% <55.55%> (-0.49%)` | :arrow_down: |
   | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `54.41% <0%> (-0.87%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.17% <0%> (-0.75%)` | :arrow_down: |
   | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
   | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | | |
   | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
   | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | | |
   | [...ssets/src/visualizations/presets/MapChartPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL01hcENoYXJ0UHJlc2V0Lmpz) | | |
   | ... and [439 more](https://codecov.io/gh/apache/incubator-superset/pull/6497/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6497?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6497?src=pr&el=footer). Last update [a2ce997...77745ff](https://codecov.io/gh/apache/incubator-superset/pull/6497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org