You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/23 12:00:00 UTC
[GitHub] [airflow] potiuk opened a new pull request #18464: Add fixing of ownership also for sources in Breeze
potiuk opened a new pull request #18464:
URL: https://github.com/apache/airflow/pull/18464
In some cases files created inside the container on linux in
sources are owned by root - so far we cleaned only some directories
that we knew were touched by Airflow, but in case of branch
switching some folders/files might also got created as owned
by root.
This PR adds AIRFLOW_SOURCES and "dags" folders to the list
of folders to fix ownership of.
This might lead to slightly longer exit time when exiting
from Breeze, but since we are running it only when the host is
Linux and the fixung is rather performant - with explicitly finding
files and dirs owned by root, this should not be a problem.
It would be much bigger problem on MacOS,Windows due to slow filesystem,
but on MacOS it is not needed as there ownership mapping is done
using the filesystem itself.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18464: Add fixing of ownership also for sources in Breeze
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18464:
URL: https://github.com/apache/airflow/pull/18464#issuecomment-925760680
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18464: Add fixing of ownership also for sources in Breeze
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18464:
URL: https://github.com/apache/airflow/pull/18464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org