[jira] [Issue Comment Edited] (GORA-66) testDeleteByQueryFields seems incorrect

["Lewis John McGibbney (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GORA-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182779#comment-13182779 ] 

Lewis John McGibbney edited comment on GORA-66 at 1/9/12 8:41 PM:
------------------------------------------------------------------

OK having been on the HBase user@ list to try to clarify how HBase treats end keys I can confirm that the test should treat them as exclusive. This is indicated in the link below

http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Scan.html#setStopRow(byte[])

So it appears you are correct Keith, however this still seems to break the build... some debugging is required I think.
                
      was (Author: lewismc):
    OK having been on the HBase user@ list to try to clarify how HBase treats end keys I can confirm that the test should treat them as exclusive. This is indicated in the link below

                  
> testDeleteByQueryFields seems incorrect
> ---------------------------------------
>
>                 Key: GORA-66
>                 URL: https://issues.apache.org/jira/browse/GORA-66
>             Project: Gora
>          Issue Type: Bug
>            Reporter: Keith Turner
>         Attachments: GORA-66-1.patch
>
>
> While writing the Accumulo backend I have been trying to run some of the existing test against it.  It seems that the test DataStoreTestUtil.testDeleteByQueryFields() has two problems.
>  * The test does not flush the store after calling deleteByQuery().  This is needed for accumulo since deletes are just inserts and must be flushed.
>  * The test expects the last key in a range that was deleted to be present.  As far as I can tell the end key in a query should be inclusive, but the test treats as exclusive.
> I will submit a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira