You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/05/20 18:17:42 UTC
[GitHub] [hive] belugabehr opened a new pull request #2303: HIVE-25144: Add NoReconnect Annotation to Create AlreadyExistsExcepti…
belugabehr opened a new pull request #2303:
URL: https://github.com/apache/hive/pull/2303
…on Methods
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2303: Add NoReconnect Annotation to CreateXXX Methods With AlreadyExistsException
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2303:
URL: https://github.com/apache/hive/pull/2303#issuecomment-846027218
@nrg4878 I have changed the title of the PR. It's not about _creating_ the exception. I've added the annotation to any createXXX method which also throws an AlreadyExistsException. It does not make sense to re-try these methods because you could be in a situation where the operation completes from the perspective of HMS but the connection is killed and then a "AlreadyExists" exception is thrown which is very confusing from the client perspective. Best to just throw an error and have the client software decide how to handle it.
re: Annotation inheritance, I'll double-check, but there already exists one on this interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2303: HIVE-25144: Add NoReconnect Annotation to CreateXXX Methods With AlreadyExistsException
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2303:
URL: https://github.com/apache/hive/pull/2303#issuecomment-857692863
@nrg4878 Here is the code I'm looking at:
https://github.com/apache/hive/blob/0c7903d7fd4675d82f653f8d305d96509a84e186/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java#L167-L176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2303: HIVE-25144: Add NoReconnect Annotation to Create AlreadyExistsExcepti…
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2303:
URL: https://github.com/apache/hive/pull/2303#issuecomment-845356962
@nrg4878 Mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #2303: HIVE-25144: Add NoReconnect Annotation to Create AlreadyExistsExcepti…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #2303:
URL: https://github.com/apache/hive/pull/2303#issuecomment-845651545
@belugabehr How does adding this annotation create AlreadyExistsException? I havent looked into this in a very long time but its my recollection that this annotation was used by either the RetryingHMSHandler or RetryingMetastoreClient to determine whether or not to retry this operation. I would have guess it was the RetryingHMSHandler but given this change, I suspect it is the latter.
So how exactly does this result in a AlreadyExistsException? What if the failure was due to a DB_LOCK timeout (Where another transaction has the lock on the table).
Also, do the implementing classes inherit annotations from the interface? I thought it was limited to just the javadoc annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2303: HIVE-25144: Add NoReconnect Annotation to CreateXXX Methods With AlreadyExistsException
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2303:
URL: https://github.com/apache/hive/pull/2303#issuecomment-857716299
@nrg4878 Thanks for the gut-check. Ignore everything I've said thus far. I was confusing things. I thought it was the client that was re-trying. It's actually the HMS Handler. Ick. Ugh. I need to dig deeper on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr closed pull request #2303: HIVE-25144: Add NoReconnect Annotation to CreateXXX Methods With AlreadyExistsException
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #2303:
URL: https://github.com/apache/hive/pull/2303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org