You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/09/22 03:17:38 UTC
[GitHub] spark pull request #22523: [MINOR] Always Close the tempFile in _serialize_t...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22523
[MINOR] Always Close the tempFile in _serialize_to_jvm
## What changes were proposed in this pull request?
Always close the tempFile after `serializer.dump_stream(data, tempFile)` in _serialize_to_jvm
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark fixMinor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22523
----
commit 01bb2096d9041323710550cc98a355631a5b71c1
Author: gatorsmile <ga...@...>
Date: 2018-09-22T03:15:06Z
minor
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22523: [MINOR][PYSPARK] Always Close the tempFile in _serialize...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22523
and branch-2.4.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22523: [MINOR] Always Close the tempFile in _serialize_to_jvm
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22523
cc @ueshin @HyukjinKwon
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22523: [MINOR][PYSPARK] Always Close the tempFile in _se...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22523#discussion_r219686544
--- Diff: python/pyspark/context.py ---
@@ -537,8 +537,10 @@ def _serialize_to_jvm(self, data, serializer, reader_func, createRDDServer):
# parallelize from there.
tempFile = NamedTemporaryFile(delete=False, dir=self._temp_dir)
--- End diff --
Actually, we better use a context manager:
```python
with NamedTemporaryFile(delete=False, dir=self._temp_dir) as tempfile:
...
```
but not a big deal. LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22523: [MINOR][PYSPARK] Always Close the tempFile in _serialize...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22523
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3372/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22523: [MINOR][PYSPARK] Always Close the tempFile in _serialize...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22523
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22523: [MINOR][PYSPARK] Always Close the tempFile in _se...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22523
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22523: [MINOR][PYSPARK] Always Close the tempFile in _serialize...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22523
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96465/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22523: [MINOR][PYSPARK] Always Close the tempFile in _serialize...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22523
**[Test build #96465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96465/testReport)** for PR 22523 at commit [`01bb209`](https://github.com/apache/spark/commit/01bb2096d9041323710550cc98a355631a5b71c1).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22523: [MINOR][PYSPARK] Always Close the tempFile in _serialize...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22523
**[Test build #96465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96465/testReport)** for PR 22523 at commit [`01bb209`](https://github.com/apache/spark/commit/01bb2096d9041323710550cc98a355631a5b71c1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22523: [MINOR][PYSPARK] Always Close the tempFile in _serialize...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22523
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org