[jira] [Commented] (IO-547) Nullpointer Exception in FileSystemUtils.freeSpaceWindows

["Michael Ernst (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IO-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157413#comment-16157413 ] 

Michael Ernst commented on IO-547:
----------------------------------

I agree with you that IllegalArgumentException is appropriate.  The documentation of freeSpaceWindows says that the `path` parameter should be a (Windows) path, and if it's not then the arguments were illegal.
IOException would also be OK according to the Javadoc.

> Nullpointer Exception in FileSystemUtils.freeSpaceWindows 
> ----------------------------------------------------------
>
>                 Key: IO-547
>                 URL: https://issues.apache.org/jira/browse/IO-547
>             Project: Commons IO
>          Issue Type: Bug
>    Affects Versions: 2.5
>         Environment: Windows OS
>            Reporter: Nikhil Shinde
>            Priority: Minor
>              Labels: beginner
>
> In FileSystemutils.freeSpaceWindows(String path,long timeout) , path cannot be null. In this function for following assignment
>           path = FilenameUtils.normalize(path,bool), path is assigned null value when 
>           (1) path argument is null.
>           (2) path argument is illegal/invalid path as per windows system.
> {code:java}
> public class FileSystemutilTest {
> 	public static void main(String args[]){
> 		FileSystemUtils fsuobj = new FileSystemUtils();
>                 String path = ":\\Users\\nikhil\\Desktop\\tests";  /* Invalid path, causes Nullpointer Exception*/
> 		try {
> 			long space = fsuobj.freeSpace(path);
> 		} catch (IOException e) {
> 			e.printStackTrace();
> 		}
> 	}
> }
> {code}
> For above test case, as path is illegal for windows system, Nullpointer exception occurs. A check for validity of path as per windows file system, will resolve this bug.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)