You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/18 09:48:32 UTC

[GitHub] [spark] zhengruifeng commented on a diff in pull request #36594: [SPARK-39223][PS] implement skew and kurt in Rolling/RollingGroupby/Expanding/ExpandingGroupby

zhengruifeng commented on code in PR #36594:
URL: https://github.com/apache/spark/pull/36594#discussion_r875696216


##########
python/pyspark/pandas/tests/test_rolling.py:
##########
@@ -37,7 +37,7 @@ def test_rolling_error(self):
             Rolling(1, 2)
 
     def _test_rolling_func(self, f):
-        pser = pd.Series([1, 2, 3], index=np.random.rand(3), name="a")
+        pser = pd.Series([1, 2, 3, 7, 9, 8], index=np.random.rand(6), name="a")

Review Comment:
   original `pser` will be too short for skew and kurt



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org