You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by se...@apache.org on 2012/01/03 20:01:29 UTC
svn commit: r1226919 - in /jmeter/trunk/src:
components/org/apache/jmeter/timers/ core/org/apache/jmeter/gui/util/
core/org/apache/jmeter/reporters/
core/org/apache/jmeter/testelement/property/ jorphan/org/apache/jorphan/util/
Author: sebb
Date: Tue Jan 3 19:01:29 2012
New Revision: 1226919
URL: http://svn.apache.org/viewvc?rev=1226919&view=rev
Log:
use Double.valueOf/Float.valueOf instead of new Double/Float (Findbugs)
Modified:
jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerBeanInfo.java
jmeter/trunk/src/core/org/apache/jmeter/gui/util/PowerTableModel.java
jmeter/trunk/src/core/org/apache/jmeter/reporters/FileReporter.java
jmeter/trunk/src/core/org/apache/jmeter/testelement/property/DoubleProperty.java
jmeter/trunk/src/core/org/apache/jmeter/testelement/property/FloatProperty.java
jmeter/trunk/src/jorphan/org/apache/jorphan/util/Converter.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerBeanInfo.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerBeanInfo.java?rev=1226919&r1=1226918&r2=1226919&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerBeanInfo.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerBeanInfo.java Tue Jan 3 19:01:29 2012
@@ -46,7 +46,7 @@ public class ConstantThroughputTimerBean
PropertyDescriptor p = property("throughput"); //$NON-NLS-1$
p.setValue(NOT_UNDEFINED, Boolean.TRUE);
- p.setValue(DEFAULT, new Double(0.0));
+ p.setValue(DEFAULT, Double.valueOf(0.0));
p = property("calcMode"); //$NON-NLS-1$
p.setValue(NOT_UNDEFINED, Boolean.TRUE);
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/util/PowerTableModel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/util/PowerTableModel.java?rev=1226919&r1=1226918&r2=1226919&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/util/PowerTableModel.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/util/PowerTableModel.java Tue Jan 3 19:01:29 2012
@@ -172,7 +172,7 @@ public class PowerTableModel extends Def
}
try {
Constructor<?> constr = colClass.getConstructor(new Class[] { Float.TYPE });
- return constr.newInstance(new Object[] { new Float(0F) });
+ return constr.newInstance(new Object[] { Float.valueOf(0F) });
} catch (NoSuchMethodException err) {
} catch (InstantiationException err) {
} catch (IllegalAccessException err) {
@@ -180,7 +180,7 @@ public class PowerTableModel extends Def
}
try {
Constructor<?> constr = colClass.getConstructor(new Class[] { Double.TYPE });
- return constr.newInstance(new Object[] { new Double(0D) });
+ return constr.newInstance(new Object[] { Double.valueOf(0D) });
} catch (NoSuchMethodException err) {
} catch (InstantiationException err) {
} catch (IllegalAccessException err) {
Modified: jmeter/trunk/src/core/org/apache/jmeter/reporters/FileReporter.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/reporters/FileReporter.java?rev=1226919&r1=1226918&r2=1226919&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/reporters/FileReporter.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/reporters/FileReporter.java Tue Jan 3 19:01:29 2012
@@ -268,17 +268,17 @@ private static class GraphPanel extends
c.gridx = 1;
c.gridy = 1;
g.setConstraints(count, c);
- JLabel min = new JLabel("Min: " + df.format(new Float(minValue)));
+ JLabel min = new JLabel("Min: " + df.format(Float.valueOf(minValue)));
c.gridx = 1;
c.gridy = 2;
g.setConstraints(min, c);
- JLabel max = new JLabel("Max: " + df.format(new Float(maxValue)));
+ JLabel max = new JLabel("Max: " + df.format(Float.valueOf(maxValue)));
c.gridx = 1;
c.gridy = 3;
g.setConstraints(max, c);
- JLabel average = new JLabel("Average: " + df.format(new Float(averageValue)));
+ JLabel average = new JLabel("Average: " + df.format(Float.valueOf(averageValue)));
c.gridx = 1;
c.gridy = 4;
Modified: jmeter/trunk/src/core/org/apache/jmeter/testelement/property/DoubleProperty.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/testelement/property/DoubleProperty.java?rev=1226919&r1=1226918&r2=1226919&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/testelement/property/DoubleProperty.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/testelement/property/DoubleProperty.java Tue Jan 3 19:01:29 2012
@@ -69,7 +69,7 @@ public class DoubleProperty extends Numb
* {@inheritDoc}
*/
public Object getObjectValue() {
- return new Double(value);
+ return Double.valueOf(value);
}
/**
Modified: jmeter/trunk/src/core/org/apache/jmeter/testelement/property/FloatProperty.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/testelement/property/FloatProperty.java?rev=1226919&r1=1226918&r2=1226919&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/testelement/property/FloatProperty.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/testelement/property/FloatProperty.java Tue Jan 3 19:01:29 2012
@@ -85,7 +85,7 @@ public class FloatProperty extends Numbe
* {@inheritDoc}
*/
public Object getObjectValue() {
- return new Float(value);
+ return Float.valueOf(value);
}
/**
Modified: jmeter/trunk/src/jorphan/org/apache/jorphan/util/Converter.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/jorphan/org/apache/jorphan/util/Converter.java?rev=1226919&r1=1226918&r2=1226919&view=diff
==============================================================================
--- jmeter/trunk/src/jorphan/org/apache/jorphan/util/Converter.java (original)
+++ jmeter/trunk/src/jorphan/org/apache/jorphan/util/Converter.java Tue Jan 3 19:01:29 2012
@@ -44,9 +44,9 @@ public class Converter {
} else if (toType.isAssignableFrom(value.getClass())) {
return value;
} else if (toType.equals(float.class) || toType.equals(Float.class)) {
- return new Float(getFloat(value));
+ return Float.valueOf(getFloat(value));
} else if (toType.equals(double.class) || toType.equals(Double.class)) {
- return new Double(getDouble(value));
+ return Double.valueOf(getDouble(value));
} else if (toType.equals(String.class)) {
return getString(value);
} else if (toType.equals(int.class) || toType.equals(Integer.class)) {