You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (Created) (JIRA)" <ji...@apache.org> on 2012/02/29 06:38:02 UTC
[jira] [Created] (CASSANDRA-3978) [patch] quell all the warnings
around DecoratorKey and generics
[patch] quell all the warnings around DecoratorKey and generics
---------------------------------------------------------------
Key: CASSANDRA-3978
URL: https://issues.apache.org/jira/browse/CASSANDRA-3978
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Dave Brosius
Priority: Trivial
Attachments: quell_decoratorkey_warnings.diff
against trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3978) [patch] quell all
the warnings around DecoratorKey and generics
Posted by "Dave Brosius (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220610#comment-13220610 ]
Dave Brosius edited comment on CASSANDRA-3978 at 3/2/12 2:21 AM:
-----------------------------------------------------------------
the only specialization is in
SecondaryIndexManager, using LocalToken as in
RandomPartitioner, using BigIntegerToken and
AbstractByteOrderedPartitioner, using BytesToken
OrderPreservingPartitioner, using StringToken
probably could de-generify it though.
was (Author: dbrosius@apache.org):
the only specialization is in
SecondaryIndexManager, using LocalToken as in
RandomPartitioner, using BigIntegerToken and
AbstractByteOrderedPartitioner, useing BytesToken
probably could de-generify it though.
> [patch] quell all the warnings around DecoratorKey and generics
> ---------------------------------------------------------------
>
> Key: CASSANDRA-3978
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3978
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: quell_decoratorkey_warnings.diff
>
>
> against trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3978) [patch] quell all the warnings
around DecoratorKey and generics
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220523#comment-13220523 ]
Jonathan Ellis commented on CASSANDRA-3978:
-------------------------------------------
Interesting. Does making DecoratedKey generic really buy us anything? I'm not sure that it's actually making anything "type safe" which would be the goal. Should we de-generify it instead?
> [patch] quell all the warnings around DecoratorKey and generics
> ---------------------------------------------------------------
>
> Key: CASSANDRA-3978
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3978
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: quell_decoratorkey_warnings.diff
>
>
> against trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3978) [patch] quell all
the warnings around DecoratorKey and generics
Posted by "Dave Brosius (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220610#comment-13220610 ]
Dave Brosius edited comment on CASSANDRA-3978 at 3/2/12 2:16 AM:
-----------------------------------------------------------------
the only specialization is in
SecondaryIndexManager, using LocalToken as in
RandomPartitioner, using BigIntegerToken and
AbstractByteOrderedPartitioner, useing BytesToken
probably could de-generify it though.
was (Author: dbrosius@apache.org):
the only specialization is in SecondaryIndexManager, using LocalToken as in
public DecoratedKey<LocalToken> getIndexKeyFor(ByteBuffer name, ByteBuffer value)
probably could de-generify it though.
> [patch] quell all the warnings around DecoratorKey and generics
> ---------------------------------------------------------------
>
> Key: CASSANDRA-3978
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3978
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: quell_decoratorkey_warnings.diff
>
>
> against trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3978) [patch] quell all the warnings
around DecoratorKey and generics
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220752#comment-13220752 ]
Sylvain Lebresne commented on CASSANDRA-3978:
---------------------------------------------
I'd be in favor of the de-generify option too, I don't think it buys us much.
> [patch] quell all the warnings around DecoratorKey and generics
> ---------------------------------------------------------------
>
> Key: CASSANDRA-3978
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3978
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: quell_decoratorkey_warnings.diff, quell_decoratorkey_warnings_2.diff
>
>
> against trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3978) [patch] quell all the warnings
around DecoratorKey and generics
Posted by "Dave Brosius (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated CASSANDRA-3978:
------------------------------------
Attachment: quell_decoratorkey_warnings_2.diff
second patch de-generifies if that is what is desired.
> [patch] quell all the warnings around DecoratorKey and generics
> ---------------------------------------------------------------
>
> Key: CASSANDRA-3978
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3978
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: quell_decoratorkey_warnings.diff, quell_decoratorkey_warnings_2.diff
>
>
> against trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3978) [patch] quell all the warnings
around DecoratorKey and generics
Posted by "Dave Brosius (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220610#comment-13220610 ]
Dave Brosius commented on CASSANDRA-3978:
-----------------------------------------
the only specialization is in SecondaryIndexManager, using LocalToken as in
public DecoratedKey<LocalToken> getIndexKeyFor(ByteBuffer name, ByteBuffer value)
probably could de-generify it though.
> [patch] quell all the warnings around DecoratorKey and generics
> ---------------------------------------------------------------
>
> Key: CASSANDRA-3978
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3978
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: quell_decoratorkey_warnings.diff
>
>
> against trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3978) [patch] quell all the warnings
around DecoratorKey and generics
Posted by "Dave Brosius (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated CASSANDRA-3978:
------------------------------------
Attachment: quell_decoratorkey_warnings.diff
> [patch] quell all the warnings around DecoratorKey and generics
> ---------------------------------------------------------------
>
> Key: CASSANDRA-3978
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3978
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: quell_decoratorkey_warnings.diff
>
>
> against trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira