You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/06 19:55:00 UTC
[jira] [Work logged] (IO-782) SequenceReader should close readers when its close method is called
[ https://issues.apache.org/jira/browse/IO-782?focusedWorklogId=814487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-814487 ]
ASF GitHub Bot logged work on IO-782:
-------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/22 19:54
Start Date: 06/Oct/22 19:54
Worklog Time Spent: 10m
Work Description: garydgregory commented on code in PR #391:
URL: https://github.com/apache/commons-io/pull/391#discussion_r989426682
##########
src/main/java/org/apache/commons/io/input/SequenceReader.java:
##########
@@ -33,19 +36,21 @@ public class SequenceReader extends Reader {
private Reader reader;
private Iterator<? extends Reader> readers;
+ private Iterable<? extends Reader> readersIterable;
/**
- * Constructs a new instance with readers
+ * Construct a new instance with readers
Review Comment:
Don't change the style of the Javadoc please. In general, don't change the style of anything when a PR is supposed to fix a bug.
Issue Time Tracking
-------------------
Worklog Id: (was: 814487)
Remaining Estimate: 0h
Time Spent: 10m
> SequenceReader should close readers when its close method is called
> -------------------------------------------------------------------
>
> Key: IO-782
> URL: https://issues.apache.org/jira/browse/IO-782
> Project: Commons IO
> Issue Type: Bug
> Components: Streams/Writers
> Affects Versions: 2.11.0
> Reporter: matteodg
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{SequenceReader.close()}} method should close readers.
> This is to be compliant with common practice of any {{Reader}} decorator, like for example {{BufferedReader}} is doing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)