You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Angela Schreiber <an...@adobe.com> on 2012/12/11 12:16:39 UTC
Re: svn commit: r1418316 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/api/
oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/
oak-core/src/main/java/org/apache/j...
hi michael
i would really appreciate if you would not comment out test-cases
that i deliberately added, just because a half-way fix of
yours makes them fail.
so, -1 for the changes made in particular the following:
> @@ -332,8 +334,8 @@ public class OakAuthorizablePropertyTest
> @Test
> public void testGetPropertyNamesByInvalidRelPath() throws Exception {
> List<String> invalidPaths = new ArrayList<String>();
> - invalidPaths.add("../");
> - invalidPaths.add("../../");
> +// invalidPaths.add("../"); // FIXME: these paths are valid on JR2
> +// invalidPaths.add("../../");
> invalidPaths.add("../testing");
> invalidPaths.add("/testing");
> invalidPaths.add(null);
and:
> Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AuthorizablePropertyTest.java
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AuthorizablePropertyTest.java?rev=1418316&r1=1418315&r2=1418316&view=diff
> ==============================================================================
> --- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AuthorizablePropertyTest.java (original)
> +++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AuthorizablePropertyTest.java Fri Dec 7 14:03:31 2012
> @@ -315,8 +315,8 @@ public class AuthorizablePropertyTest ex
> @Test
> public void testGetPropertyNamesByInvalidRelPath() throws NotExecutableException, RepositoryException {
> List<String> invalidPaths = new ArrayList<String>();
> - invalidPaths.add("../");
> - invalidPaths.add("../../");
> +// invalidPaths.add("../"); // FIXME: these paths are valid on JR2
> +// invalidPaths.add("../../");
> invalidPaths.add("../testing");
> invalidPaths.add("/testing");
> invalidPaths.add(null);
consider this to be a veto. please revert the modifications.
kind regards
angela
Re: svn commit: r1418316 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/api/
oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/
oak-core/src/main/java/org/apache/j...
Posted by Michael Dürig <mi...@gmail.com>.
On 11.12.12 11:16, Angela Schreiber wrote:
> hi michael
>
> i would really appreciate if you would not comment out test-cases
> that i deliberately added, just because a half-way fix of
> yours makes them fail.
It's the half way hack of yours which made them pass in the first place.
>
> consider this to be a veto. please revert the modifications.
Ok which means OAk-426 will be won't fix.
Michael
>
> kind regards
> angela
>