You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/08 09:10:34 UTC
[GitHub] [kafka] cadonna commented on a change in pull request #10835: KAFKA-12905: Replace EasyMock and PowerMock with Mockito for NamedCacheMetricsTest
cadonna commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r647259690
##########
File path: streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/NamedCacheMetricsTest.java
##########
@@ -49,37 +41,28 @@
private static final String HIT_RATIO_MIN_DESCRIPTION = "The minimum cache hit ratio";
private static final String HIT_RATIO_MAX_DESCRIPTION = "The maximum cache hit ratio";
- private final StreamsMetricsImpl streamsMetrics = createMock(StreamsMetricsImpl.class);
- private final Sensor expectedSensor = mock(Sensor.class);
+ private Sensor expectedSensor = Mockito.mock(Sensor.class);
private final Map<String, String> tagMap = mkMap(mkEntry("key", "value"));
@Test
public void shouldGetHitRatioSensorWithBuiltInMetricsVersionCurrent() {
final String hitRatio = "hit-ratio";
- mockStatic(StreamsMetricsImpl.class);
- expect(streamsMetrics.version()).andStubReturn(Version.LATEST);
- expect(streamsMetrics.cacheLevelSensor(THREAD_ID, TASK_ID, STORE_NAME, hitRatio, RecordingLevel.DEBUG))
- .andReturn(expectedSensor);
- expect(streamsMetrics.cacheLevelTagMap(THREAD_ID, TASK_ID, STORE_NAME)).andReturn(tagMap);
+ final StreamsMetricsImpl streamsMetrics = Mockito.mock(StreamsMetricsImpl.class);
+ Mockito.when(streamsMetrics.cacheLevelSensor(THREAD_ID, TASK_ID, STORE_NAME, hitRatio, RecordingLevel.DEBUG)).thenReturn(expectedSensor);
+ Mockito.when(streamsMetrics.cacheLevelTagMap(THREAD_ID, TASK_ID, STORE_NAME)).thenReturn(tagMap);
StreamsMetricsImpl.addAvgAndMinAndMaxToSensor(
- expectedSensor,
- StreamsMetricsImpl.CACHE_LEVEL_GROUP,
- tagMap,
- hitRatio,
- HIT_RATIO_AVG_DESCRIPTION,
- HIT_RATIO_MIN_DESCRIPTION,
- HIT_RATIO_MAX_DESCRIPTION);
- replay(streamsMetrics);
- replay(StreamsMetricsImpl.class);
+ expectedSensor,
+ StreamsMetricsImpl.CACHE_LEVEL_GROUP,
+ tagMap,
+ hitRatio,
+ HIT_RATIO_AVG_DESCRIPTION,
+ HIT_RATIO_MIN_DESCRIPTION,
+ HIT_RATIO_MAX_DESCRIPTION);
Review comment:
nit
```suggestion
expectedSensor,
StreamsMetricsImpl.CACHE_LEVEL_GROUP,
tagMap,
hitRatio,
HIT_RATIO_AVG_DESCRIPTION,
HIT_RATIO_MIN_DESCRIPTION,
HIT_RATIO_MAX_DESCRIPTION
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org