You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/22 11:23:30 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #5688: Minor: Add logo back to sidebar

alamb opened a new pull request, #5688:
URL: https://github.com/apache/arrow-datafusion/pull/5688

   # Which issue does this PR close?
   re #5500 
   
   # Rationale for this change
   
   While working https://github.com/apache/arrow-datafusion/pull/5670 we lost the sidebar logo
   
   ![Screenshot 2023-03-22 at 7 22 38 AM](https://user-images.githubusercontent.com/490673/226889765-6b702bc4-5eac-4e1e-bdcd-c8f998dbeb78.png)
   
   # What changes are included in this PR?
   
   Add the logo back in
   
   ![Screenshot 2023-03-22 at 7 21 55 AM](https://user-images.githubusercontent.com/490673/226889601-3697c200-5d21-485c-86ec-210f18157855.png)
   
   # Are these changes tested?
   
   Tested locally
   
   # Are there any user-facing changes?
   
   docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5688: Docs: Add logo back to sidebar

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5688:
URL: https://github.com/apache/arrow-datafusion/pull/5688#discussion_r1144650594


##########
docs/source/_templates/docs-sidebar.html:
##########
@@ -14,3 +14,8 @@
     {% endif %}
   </div>
 </nav>
+
+
+<a class="navbar-brand" href="{{ pathto(master_doc) }}">
+  <img src="{{ pathto('_static/images/DataFusion-Logo-Background-White.png', 1) }}" class="logo" alt="logo">

Review Comment:
   this used to be
   
   ```
     <img src="{{ pathto('_static/images' + logo, 1) }}" class="logo" alt="logo">
   ```
   
   But then sphinx complained that `logo` wasn't defined -- so I just hard coded it to match the main logo
   
   https://github.com/apache/arrow-datafusion/blob/af97ac886c425efefb0536c5344894703f65d7fa/docs/source/conf.py#L103
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] mslapek commented on pull request #5688: Docs: Add logo back to sidebar

Posted by "mslapek (via GitHub)" <gi...@apache.org>.
mslapek commented on PR #5688:
URL: https://github.com/apache/arrow-datafusion/pull/5688#issuecomment-1479968977

   Kinda stupid question... why logo is at the bottom? 🤔


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #5688: Docs: Add logo back to sidebar

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5688:
URL: https://github.com/apache/arrow-datafusion/pull/5688#issuecomment-1480051879

   >  Kinda stupid question... why logo is at the bottom? 🤔
   
   
   TLDR is "I don't know"  -- I was just putting it back where I found it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener merged pull request #5688: Docs: Add logo back to sidebar

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #5688:
URL: https://github.com/apache/arrow-datafusion/pull/5688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #5688: Docs: Add logo back to sidebar

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5688:
URL: https://github.com/apache/arrow-datafusion/pull/5688#issuecomment-1479616045

   It is so cool it is already live on https://arrow.apache.org/datafusion/ ❤️ 
   
   ![Screenshot 2023-03-22 at 9 58 03 AM](https://user-images.githubusercontent.com/490673/226927269-e132f591-e8cc-4d31-88a4-a317e5e68d71.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org