You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/11/19 01:27:54 UTC

Review Request 40464: Fixed a few style issues in HDFS wrapper code.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40464/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.


Bugs: MESOS-3951
    https://issues.apache.org/jira/browse/MESOS-3951


Repository: mesos


Description
-------

Fixed a few style issues in HDFS wrapper code.


Diffs
-----

  src/hdfs/hdfs.hpp 6604938e8ca1962db1f0159d175f52fd5c03dd3c 
  src/hdfs/hdfs.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40464/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 40464: Fixed a few style issues in HDFS wrapper code.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40464/#review107409
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Nov. 19, 2015, 10:16 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40464/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 10:16 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3951
>     https://issues.apache.org/jira/browse/MESOS-3951
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a few style issues in HDFS wrapper code.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.hpp 6604938e8ca1962db1f0159d175f52fd5c03dd3c 
>   src/hdfs/hdfs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40464/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 40464: Fixed a few style issues in HDFS wrapper code.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40464/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 10:16 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.


Changes
-------

Removed a few unnecessary temp variable.


Bugs: MESOS-3951
    https://issues.apache.org/jira/browse/MESOS-3951


Repository: mesos


Description
-------

Fixed a few style issues in HDFS wrapper code.


Diffs (updated)
-----

  src/hdfs/hdfs.hpp 6604938e8ca1962db1f0159d175f52fd5c03dd3c 
  src/hdfs/hdfs.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40464/diff/


Testing
-------

make check


Thanks,

Jie Yu