You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/07/15 22:40:43 UTC
Review Request 23521: Fix KAFKA-1533
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23521/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1533
https://issues.apache.org/jira/browse/KAFKA-1533
Repository: kafka
Description
-------
1. Add the metadataRefreshAttemptMS in NetworkClient for backing off; 2. Refactor Producer API tests using KafkaTestHarness; 3. Change default backoff time to 100ms for test utils
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java d8f9ce663ee24d2b0852c974136741280c39f8f8
clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java 4aa5b01d611631db72df47d50bbe30edb8c478db
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 15fd5bcbaf175a0f7d7cf0b142e63f705ca9b6ae
core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 34a7db4b4ea2b720476c2b1f22a623a997faffbc
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 194dd70919a5f301d3131c56594e40a0ebb27311
core/src/test/scala/unit/kafka/utils/TestUtils.scala 3faa884f8eb83c7c00baab416d0acfb488dc39c1
Diff: https://reviews.apache.org/r/23521/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 23521: Fix KAFKA-1533
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23521/#review48102
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
<https://reviews.apache.org/r/23521/#comment84403>
how about renaming this to metadataLastUpdateAttemptMs vs MS to conform with convention?
- Neha Narkhede
On July 15, 2014, 8:40 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23521/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 8:40 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1533
> https://issues.apache.org/jira/browse/KAFKA-1533
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Add the metadataRefreshAttemptMS in NetworkClient for backing off; 2. Refactor Producer API tests using KafkaTestHarness; 3. Change default backoff time to 100ms for test utils
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/NetworkClient.java d8f9ce663ee24d2b0852c974136741280c39f8f8
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java 4aa5b01d611631db72df47d50bbe30edb8c478db
> core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 15fd5bcbaf175a0f7d7cf0b142e63f705ca9b6ae
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 34a7db4b4ea2b720476c2b1f22a623a997faffbc
> core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 194dd70919a5f301d3131c56594e40a0ebb27311
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 3faa884f8eb83c7c00baab416d0acfb488dc39c1
>
> Diff: https://reviews.apache.org/r/23521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 23521: Fix KAFKA-1533
Posted by Guozhang Wang <gu...@linkedin.com>.
> On July 16, 2014, 11:25 p.m., Jun Rao wrote:
> > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, lines 360-361
> > <https://reviews.apache.org/r/23521/diff/1/?file=632795#file632795line360>
> >
> > If a node can be connected, but is not connected yet, will the metadata be delayed by up to backoff time?
Yes it will, I think since this case is not frequent it should be fine?
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23521/#review47959
-----------------------------------------------------------
On July 15, 2014, 8:40 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23521/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 8:40 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1533
> https://issues.apache.org/jira/browse/KAFKA-1533
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Add the metadataRefreshAttemptMS in NetworkClient for backing off; 2. Refactor Producer API tests using KafkaTestHarness; 3. Change default backoff time to 100ms for test utils
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/NetworkClient.java d8f9ce663ee24d2b0852c974136741280c39f8f8
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java 4aa5b01d611631db72df47d50bbe30edb8c478db
> core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 15fd5bcbaf175a0f7d7cf0b142e63f705ca9b6ae
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 34a7db4b4ea2b720476c2b1f22a623a997faffbc
> core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 194dd70919a5f301d3131c56594e40a0ebb27311
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 3faa884f8eb83c7c00baab416d0acfb488dc39c1
>
> Diff: https://reviews.apache.org/r/23521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 23521: Fix KAFKA-1533
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23521/#review47959
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
<https://reviews.apache.org/r/23521/#comment84208>
If a node can be connected, but is not connected yet, will the metadata be delayed by up to backoff time?
clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java
<https://reviews.apache.org/r/23521/#comment84209>
Does this need to be public?
- Jun Rao
On July 15, 2014, 8:40 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23521/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 8:40 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1533
> https://issues.apache.org/jira/browse/KAFKA-1533
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Add the metadataRefreshAttemptMS in NetworkClient for backing off; 2. Refactor Producer API tests using KafkaTestHarness; 3. Change default backoff time to 100ms for test utils
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/NetworkClient.java d8f9ce663ee24d2b0852c974136741280c39f8f8
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java 4aa5b01d611631db72df47d50bbe30edb8c478db
> core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 15fd5bcbaf175a0f7d7cf0b142e63f705ca9b6ae
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 34a7db4b4ea2b720476c2b1f22a623a997faffbc
> core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 194dd70919a5f301d3131c56594e40a0ebb27311
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 3faa884f8eb83c7c00baab416d0acfb488dc39c1
>
> Diff: https://reviews.apache.org/r/23521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>