You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "jmuehlner (via GitHub)" <gi...@apache.org> on 2024/08/22 17:58:41 UTC
[PR] GUACAMOLE-1979: Allow setting required properties for connecting to MySQL 8.4 and later. [guacamole-client]
jmuehlner opened a new pull request, #1007:
URL: https://github.com/apache/guacamole-client/pull/1007
These properties allow connecting to a MySQL 8.4+ database server.
Either the public key can be retrieved from the server and set using the `mysql-server-rsa-public-key-file` property, or the public key can be automatically retrieved by setting the `mysql-allow-public-key-retrieval` property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1979: Allow setting required properties for connecting to MySQL 8.4 and later. [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #1007:
URL: https://github.com/apache/guacamole-client/pull/1007#issuecomment-2305581202
Changes look fine to me. Do older drivers and/or MySQL/MariaDB servers that don't support these properties react okay if/when they are set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1979: Allow setting required properties for connecting to MySQL 8.4 and later. [guacamole-client]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #1007:
URL: https://github.com/apache/guacamole-client/pull/1007#issuecomment-2307524874
> Changes look fine to me. Do older drivers and/or MySQL/MariaDB servers that don't support these properties react okay if/when they are set?
Yep, confirmed that all of these new properties don't do anything when connecting to a database that doesn't support them. I tested with MySQL 5.3 and tried setting `allowPublicKeyRetrieval` to both "true" and "false", as well as setting `serverRsaPublicKeyFile` to both valid and invalid file paths, and everything was ignored.
I also tried setting various invalid/unknown properties with both the MySQL and MariaDB drivers and they were simply ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1979: Allow setting required properties for connecting to MySQL 8.4 and later. [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #1007:
URL: https://github.com/apache/guacamole-client/pull/1007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1979: Allow setting required properties for connecting to MySQL 8.4 and later. [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #1007:
URL: https://github.com/apache/guacamole-client/pull/1007#issuecomment-2307540413
@jmuehlner One other question - this is currently targeted at the `main` branch - wasn't sure if the aim is to get this into the 1.6.0 release, or you're good with it waiting until the next one? Don't know if you're considering it a bug or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1979: Allow setting required properties for connecting to MySQL 8.4 and later. [guacamole-client]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #1007:
URL: https://github.com/apache/guacamole-client/pull/1007#issuecomment-2307577943
> @jmuehlner One other question - this is currently targeted at the `main` branch - wasn't sure if the aim is to get this into the 1.6.0 release, or you're good with it waiting until the next one? Don't know if you're considering it a bug or not?
Yeah, I was thinking it might be better to avoid increasing the scope of 1.6.0 further. This isn't really a bug exactly - it's more of an improvement enabling the use of later MySQL versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org