You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/09/07 00:52:39 UTC

[Bug 120837] New: Update internal boost to version 1.48

https://issues.apache.org/ooo/show_bug.cgi?id=120837

          Priority: P3
            Bug ID: 120837
          Assignee: ooo-issues@incubator.apache.org
           Summary: Update internal boost to version 1.48
          Severity: major
        Issue Type: DEFECT
    Classification: Code
                OS: All
          Reporter: pfg@apache.org
          Hardware: All
            Status: CONFIRMED
           Version: AOO350-dev
         Component: www
           Product: external prerequisites

Created attachment 79325
  --> https://issues.apache.org/ooo/attachment.cgi?id=79325&action=edit
Patch for updating boost to version 1.48

I have a preliminary patch to update boost and I also include the patches from
FreeBSD's native port which is known to build with gcc 4.2.1 and clang 3.1.

FreeBSD uses Boost version 1.48 which offers better compatibility with newer
compilers and in particular clang.

Testers are required for the Windows, linux and MacOS X builds.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79325|0                           |1
        is obsolete|                            |
  Attachment #79356|                            |review?
              Flags|                            |

--- Comment #2 from Pedro Giffuni <pf...@apache.org> ---
Created attachment 79356
  --> https://issues.apache.org/ooo/attachment.cgi?id=79356&action=edit
Updated patch

The previous diff didn't work because I used SVN mv for the base boost patch
and svn diff didn't know it had to copy the old file first.

This new version should work fine. I also added more headers to the delivery
list.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Pedro Giffuni <pf...@apache.org> ---
Issue in setup_native was fixed by orw in r1389287.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://issues.apache.org/o |
                   |oo/show_bug.cgi?id=120847   |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Issue Type|DEFECT                      |PATCH
           See Also|                            |https://issues.apache.org/o
                   |                            |oo/show_bug.cgi?id=109450

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79356|0                           |1
        is obsolete|                            |
  Attachment #79356|review?                     |
              Flags|                            |

--- Comment #5 from Pedro Giffuni <pf...@apache.org> ---
Created attachment 79447
  --> https://issues.apache.org/ooo/attachment.cgi?id=79447&action=edit
Work in Progress but may even work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

--- Comment #7 from Pedro Giffuni <pf...@apache.org> ---
(In reply to comment #6)
> The patch does not deliver header files in
> main\solver\350\wntmsci12.pro\inc\boost\lambda, then cause the break in sc
> module when compiling sc\source\core\data\column3.cxx
> 
> column3.cxx:36 error: boost/lambda/bind.hpp: No such file or directory
> column3.cxx:38 error: boost/lambda/lambda.hpp: No such file or directory

lambda/bind.hpp doesn't exist anymore. There is a 
bind/bind.hpp

There is a lambda/lamda.hpp though and it should be delivered.

I still have to complete the delivery list but this is all very strange: AOO
builds using the external boost 1.48.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79512|0                           |1
        is obsolete|                            |

--- Comment #10 from Pedro Giffuni <pf...@apache.org> ---
Created attachment 79517
  --> https://issues.apache.org/ooo/attachment.cgi?id=79517&action=edit
Boost update

 r1381946 did a strange trick to deliver some extra headers used in #i120847#:
attempt to follow the change with the newer boost too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

--- Comment #4 from Pedro Giffuni <pf...@apache.org> ---
(In reply to comment #3)
...
> Seems that the "preprocessed" directory is not generated in my boost header
> path under solver module.
> Is this problem not existing on your FreeBSD environment?

Thank you for the report. I actually only made sure that the boost part builds
and I didn't go far enough in the build. The problem is/was there are several
"preprocessed" subdirectories that are missing in the file
main/boost/prj/d.lst

It is something easy to fix but it will take some time.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://issues.apache.org/o
                   |                            |oo/show_bug.cgi?id=120847

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://issues.apache.org/o |
                   |oo/show_bug.cgi?id=109450   |
   Target Milestone|---                         |AOO 3.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

--- Comment #14 from SVN Robot <sv...@dev.null.org> ---
"pfg" committed SVN revision 1387438 into trunk:
#i120837# - Update internal boost to version 1.48.0Re-sort the patches:
prese...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

--- Comment #8 from Pedro Giffuni <pf...@apache.org> ---
(In reply to comment #6)
> The patch does not deliver header files in
> main\solver\350\wntmsci12.pro\inc\boost\lambda, then cause the break in sc
> module when compiling sc\source\core\data\column3.cxx
> 
> column3.cxx:36 error: boost/lambda/bind.hpp: No such file or directory
> column3.cxx:38 error: boost/lambda/lambda.hpp: No such file or directory

These headers were introduced by this commit:
http://svn.apache.org/viewvc?view=revision&revision=1381946

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79447|0                           |1
        is obsolete|                            |

--- Comment #9 from Pedro Giffuni <pf...@apache.org> ---
Created attachment 79512
  --> https://issues.apache.org/ooo/attachment.cgi?id=79512&action=edit
Boost update.

This patch completes the delivery of the headers. It should be complete but the
process is error prone since I am human.

As noticed, some files might have disappeared or changed place.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79517|0                           |1
        is obsolete|                            |

--- Comment #11 from Pedro Giffuni <pf...@apache.org> ---
Created attachment 79518
  --> https://issues.apache.org/ooo/attachment.cgi?id=79518&action=edit
Boost update (cleaned up)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

--- Comment #12 from zjchen <zj...@apache.org> ---
The patches build completely on my Win7 and MacOSX environment. It is OK for
me:)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
         Issue Type|PATCH                       |TASK
   Target Milestone|---                         |AOO 4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED

--- Comment #15 from Pedro Giffuni <pf...@apache.org> ---
There are some linking issues when building with -enable-dbgutil on Windows ,
but otherwise the update went well on all platforms.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

--- Comment #3 from zjchen <zj...@apache.org> ---
Thanks for you updated patch and reply:)

I have checked the updated patch on my Mac OSX 10.7 and Windows 7 build
environment.
Both return me the break in canvas module when compiling
main/canvas/source/null/null_spritecanvashelper.cxx

The break info is that
"
/trunk/main/solver/350/wntmsci12.pro/inc\boost/numeric/conversion/detail/numeric_cast_traits.hpp(10)
: fatal error C1083: Cannot open include file:
'boost/numeric/conversion/detail/preprocessed/numeric_cast_traits.hpp': No such
file or directory
dmake:  Error code 2, while making
'../../wntmsci12.pro/slo/null_spritecanvashelper.obj'
"
Seems that the "preprocessed" directory is not generated in my boost header
path under solver module.
Is this problem not existing on your FreeBSD environment?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

Pedro Giffuni <pf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79325|0                           |1
           is patch|                            |
  Attachment #79325|application/octet-stream    |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

zjchen <zj...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zjchen@apache.org

--- Comment #1 from zjchen <zj...@apache.org> ---
I would like to help to check whether the patches work in Mac OS building
environment.

A first attempt failed at applying boots_1_48_0.patch
I use command "git apply --check patch-boost" under main module. it returns me
that "error: patch failed: boost/boost_1_48_0.patch:1".
also failed when using "patch -p0 -i patch-boost" to apply

should I create the boost_1_48_0.patch manually?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

--- Comment #13 from SVN Robot <sv...@dev.null.org> ---
"pfg" committed SVN revision 1386635 into trunk:
#i120837# - Update internal boost to version 1.48Newer version of boost have
...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120837] Update internal boost to version 1.48

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120837

--- Comment #6 from zjchen <zj...@apache.org> ---
The patch does not deliver header files in
main\solver\350\wntmsci12.pro\inc\boost\lambda, then cause the break in sc
module when compiling sc\source\core\data\column3.cxx

column3.cxx:36 error: boost/lambda/bind.hpp: No such file or directory
column3.cxx:38 error: boost/lambda/lambda.hpp: No such file or directory

-- 
You are receiving this mail because:
You are the assignee for the bug.