You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/16 12:00:48 UTC
[GitHub] [superset] amitmiran137 opened a new pull request #12570: refactor: extract to method is_user_admin
amitmiran137 opened a new pull request #12570:
URL: https://github.com/apache/superset/pull/12570
### SUMMARY
a simple method that checks if a user is an admin and reuses it instead of code duplications
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 66.75% -0.01%
==========================================
Files 1015 1015
Lines 49633 49634 +1
Branches 4839 4970 +131
==========================================
- Hits 33133 33132 -1
- Misses 16377 16379 +2
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `60.74% <ø> (ø)` | |
| python | `63.95% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `7.80%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 58.95% -7.81%
==========================================
Files 1015 959 -56
Lines 49633 46870 -2763
Branches 4839 4353 -486
==========================================
- Hits 33133 27631 -5502
- Misses 16377 19239 +2862
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.44% <100.00%> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [388 more](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 66.67% -0.09%
==========================================
Files 1015 1015
Lines 49633 49634 +1
Branches 4839 4970 +131
==========================================
- Hits 33133 33093 -40
- Misses 16377 16418 +41
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `60.74% <ø> (ø)` | |
| python | `63.82% <100.00%> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `3.33%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 63.41% -3.34%
==========================================
Files 1015 486 -529
Lines 49633 29951 -19682
Branches 4839 0 -4839
==========================================
- Hits 33133 18994 -14139
+ Misses 16377 10957 -5420
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.41% <100.00%> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [536 more](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `3.30%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 63.45% -3.31%
==========================================
Files 1015 486 -529
Lines 49633 29951 -19682
Branches 4839 0 -4839
==========================================
- Hits 33133 19005 -14128
+ Misses 16377 10946 -5431
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.45% <100.00%> (-0.52%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.57% <0.00%> (-0.02%)` | :arrow_down: |
| ... and [534 more](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 66.75% -0.01%
==========================================
Files 1015 1015
Lines 49633 49634 +1
Branches 4839 4970 +131
==========================================
- Hits 33133 33132 -1
- Misses 16377 16379 +2
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `60.74% <ø> (ø)` | |
| python | `63.95% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 66.75% -0.01%
==========================================
Files 1015 1015
Lines 49633 49634 +1
Branches 4839 4970 +131
==========================================
- Hits 33133 33132 -1
- Misses 16377 16379 +2
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `60.74% <ø> (ø)` | |
| python | `63.95% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
========================================
Coverage 66.75% 66.75%
========================================
Files 1015 1015
Lines 49633 49634 +1
Branches 4839 4970 +131
========================================
+ Hits 33133 33135 +2
+ Misses 16377 16376 -1
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `60.74% <ø> (ø)` | |
| python | `63.96% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 66.67% -0.08%
==========================================
Files 1015 1015
Lines 49633 49634 +1
Branches 4839 4970 +131
==========================================
- Hits 33133 33094 -39
- Misses 16377 16417 +40
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `60.74% <ø> (ø)` | |
| python | `63.83% <100.00%> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12570:
URL: https://github.com/apache/superset/pull/12570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 66.75% -0.01%
==========================================
Files 1015 1015
Lines 49633 49634 +1
Branches 4839 4970 +131
==========================================
- Hits 33133 33132 -1
- Misses 16377 16379 +2
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `60.74% <ø> (ø)` | |
| python | `63.95% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-0.65%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #12570:
URL: https://github.com/apache/superset/pull/12570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12570: refactor: extract to method is_user_admin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12570:
URL: https://github.com/apache/superset/pull/12570#issuecomment-761554294
# [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=h1) Report
> Merging [#12570](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=desc) (f15f201) into [master](https://codecov.io/gh/apache/superset/commit/deebd6f7388f0c61481845dc5c4f3e26c7bc36ca?el=desc) (deebd6f) will **decrease** coverage by `0.31%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12570 +/- ##
==========================================
- Coverage 66.75% 66.44% -0.32%
==========================================
Files 1015 1015
Lines 49633 49634 +1
Branches 4839 4970 +131
==========================================
- Hits 33133 32978 -155
- Misses 16377 16533 +156
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `60.74% <ø> (ø)` | |
| python | `63.44% <100.00%> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.96% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.41% <100.00%> (+0.20%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12570/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=footer). Last update [deebd6f...f15f201](https://codecov.io/gh/apache/superset/pull/12570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org