You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/25 09:58:49 UTC

[GitHub] [pulsar] congbobo184 opened a new pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

congbobo184 opened a new pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362


   ## Motivation
   fix https://github.com/apache/pulsar/issues/10360
   ## implement
   change partition to one.
   
   Does this pull request potentially affect one of the following parts:
   If yes was chosen, please highlight the changes
   
   Dependencies (does it add or upgrade a dependency): (no)
   The public API: (no)
   The schema: (no)
   The default values of configurations: (no)
   The wire protocol: (no)
   The rest endpoints: (no)
   The admin cli options: (no)
   Anything that affects deployment: (no)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362#issuecomment-826295476


   @lhotari fix complete. Please review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] lhotari commented on pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362#issuecomment-826313030


   > @congbobo184 @lhotari Seems the master branch broken, `CI - Unit - Brokers - Other / unit-tests (pull_request)` always timeout.
   
   Yes, reported as #10356 . I'm testing a fix in a separate branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362#issuecomment-826307418






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] lhotari commented on pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362#issuecomment-826313030


   > @congbobo184 @lhotari Seems the master branch broken, `CI - Unit - Brokers - Other / unit-tests (pull_request)` always timeout.
   
   Yes, reported as #10356 . I'm testing a fix in a separate branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362#issuecomment-826307418


   @congbobo184 @lhotari Seems the master branch broken, `CI - Unit - Brokers - Other / unit-tests (pull_request)` always timeout.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362#issuecomment-826313211


   @codelipenghui it don't a bug on multiple partitions. if this test use multiple partition, it will become flaky.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362#issuecomment-826307813


   @congbobo184 I noticed you have changed the partitions to 1, is this a bug on multiple partitions? If yes, we should fix the bug first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #10362: [Transaction] Fix flaky txnMessageAckTest.

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #10362:
URL: https://github.com/apache/pulsar/pull/10362#issuecomment-826295476






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org