You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/19 02:56:17 UTC
[GitHub] [pulsar] momo-jun opened a new pull request, #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
momo-jun opened a new pull request, #15210:
URL: https://github.com/apache/pulsar/pull/15210
### Motivation
To align with code PR #14542 #14569 .
### Modifications
1. Add `managedCursorInfoCompressionType` to the config section of broker and standalone.
2. Update the description of `tlsProvider` to the config section of broker, standalone and proxy.
### Documentation
- [ ] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r861638993
##########
site2/docs/reference-configuration.md:
##########
@@ -710,6 +711,8 @@ You can set the log level and configuration in the [log4j2.yaml](https://github
|isAllowAutoUpdateSchemaEnabled|Allow schema to be auto updated at broker level.|true|
|schemaCompatibilityStrategy| The schema compatibility strategy at broker level, see [here](schema-evolution-compatibility.md#schema-compatibility-check-strategy) for available values.|FULL|
|systemTopicSchemaCompatibilityStrategy| The schema compatibility strategy is used for system topics, see [here](schema-evolution-compatibility.md#schema-compatibility-check-strategy) for available values.|ALWAYS_COMPATIBLE|
+|managedCursorInfoCompressionType | The compression type of managed cursor information. <br />Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and `SNAPPY`). <br />If this value is `NONE` or invalid, managed cursor information is not compressed. | NONE
Review Comment:
```suggestion
|managedCursorInfoCompressionType | The compression type of managed cursor information. <br />Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and `SNAPPY`).| NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#issuecomment-1128578898
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r873366836
##########
site2/docs/reference-configuration.md:
##########
@@ -756,6 +761,8 @@ The following parameters have been deprecated in the `conf/standalone.conf` file
|tlsCertificateFilePath|||
|tlsKeyFilePath |||
|tlsTrustCertsFilePath|||
+|tlsProvider | The TLS provider for websocket. Available values: `SunJSSE`, `Conscrypt` and etc. | Conscrypt |
Review Comment:
```suggestion
|tlsProvider | The TLS provider for websocket. Available values: `SunJSSE`, `Conscrypt`, and so on. | Conscrypt |
```
##########
site2/docs/reference-configuration.md:
##########
@@ -810,6 +817,7 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tlsRequireTrustedClientCertOnConnect| Whether client certificates are required for TLS. Connections are rejected if the client certificate isn’t trusted. |false|
|tlsProtocols|Specify the tls protocols the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLSv1.3```, ```TLSv1.2``` ||
|tlsCiphers|Specify the tls cipher the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256```||
+|tlsProvider| The TLS provider for the broker service. <br />When TLS authentication with CACert is used, the valid value is either `OPENSSL` or `JDK`.<br />When TLS authentication with KeyStore is used, available options can be `SunJSSE`, `Conscrypt` and so on. | N/A
Review Comment:
```suggestion
|tlsProvider| The TLS provider for the broker service. <br />When TLS authentication with CACert is used, the valid value is either `OPENSSL` or `JDK`.<br />When TLS authentication with KeyStore is used, available options can be `SunJSSE`, `Conscrypt`, and so on. | N/A
```
##########
site2/docs/reference-configuration.md:
##########
@@ -756,6 +761,8 @@ The following parameters have been deprecated in the `conf/standalone.conf` file
|tlsCertificateFilePath|||
|tlsKeyFilePath |||
|tlsTrustCertsFilePath|||
+|tlsProvider | The TLS provider for websocket. Available values: `SunJSSE`, `Conscrypt` and etc. | Conscrypt |
Review Comment:
<img width="980" alt="image" src="https://user-images.githubusercontent.com/50226895/168532918-700c8131-f89a-4157-8b4d-365091bba7fe.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #15210:
URL: https://github.com/apache/pulsar/pull/15210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r873372513
##########
site2/docs/reference-configuration.md:
##########
@@ -756,6 +761,8 @@ The following parameters have been deprecated in the `conf/standalone.conf` file
|tlsCertificateFilePath|||
|tlsKeyFilePath |||
|tlsTrustCertsFilePath|||
+|tlsProvider | The TLS provider for websocket. Available values: `SunJSSE`, `Conscrypt` and etc. | Conscrypt |
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r861638619
##########
site2/docs/reference-configuration.md:
##########
@@ -379,6 +379,7 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size is greater
| brokerEntryMetadataInterceptors | Set broker entry metadata interceptors.<br /><br />Multiple interceptors should be separated by commas. <br /><br />Available values:<li>org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor</li><li>org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor</li> <br /><br />Example<br />brokerEntryMetadataInterceptors=org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor, org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor|N/A |
| enableExposingBrokerEntryMetadataToClient|Whether to expose broker entry metadata to client or not.<br /><br />Available values:<li>true</li><li>false</li><br />Example<br />enableExposingBrokerEntryMetadataToClient=true | false |
| strictBookieAffinityEnabled | Enable or disable the strict bookie isolation strategy. If enabled, <br /> - `bookie-ensemble` first tries to choose bookies that belong to a namespace's affinity group. If the number of bookies is not enough, then the rest bookies are chosen. <br /> - If namespace has no affinity group, `bookie-ensemble` only chooses bookies that belong to no region. If the number of bookies is not enough, `BKNotEnoughBookiesException` is thrown.| false |
+|managedCursorInfoCompressionType | The compression type of managed cursor information. <br />Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and `SNAPPY`). <br />If this value is `NONE` or invalid, managed cursor information is not compressed. | NONE
Review Comment:
```suggestion
|managedCursorInfoCompressionType | The compression type of managed cursor information. <br />Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and `SNAPPY`).| NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#issuecomment-1101943791
@momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#issuecomment-1118251271
Hi @nodece I added docs for https://github.com/apache/pulsar/pull/13740. Can you pls review again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r865633151
##########
site2/docs/reference-configuration.md:
##########
@@ -802,6 +809,7 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tlsRequireTrustedClientCertOnConnect| Whether client certificates are required for TLS. Connections are rejected if the client certificate isn’t trusted. |false|
|tlsProtocols|Specify the tls protocols the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLSv1.3```, ```TLSv1.2``` ||
|tlsCiphers|Specify the tls cipher the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256```||
+|tlsProvider| The TLS provider for the broker service. <br />When TLS authentication with CACert is used, the valid value is either `OPENSSL` or `JDK`.<br />When TLS authentication with KeyStore is used, available options can be `SunJSSE`, `Conscrypt` and so on. | N/A
Review Comment:
N/A -> Conscrypt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r865639621
##########
site2/docs/reference-configuration.md:
##########
@@ -802,6 +809,7 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tlsRequireTrustedClientCertOnConnect| Whether client certificates are required for TLS. Connections are rejected if the client certificate isn’t trusted. |false|
|tlsProtocols|Specify the tls protocols the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLSv1.3```, ```TLSv1.2``` ||
|tlsCiphers|Specify the tls cipher the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256```||
+|tlsProvider| The TLS provider for the broker service. <br />When TLS authentication with CACert is used, the valid value is either `OPENSSL` or `JDK`.<br />When TLS authentication with KeyStore is used, available options can be `SunJSSE`, `Conscrypt` and so on. | N/A
Review Comment:
Seems it is left blank --> https://github.com/apache/pulsar/pull/13740/files#diff-f6021f4eb78412cb22fddd64b711e74ef794d071f45200a1997a9e682077895aL79.
@nodece Can you pls double-check the default tls provider for proxy? For websocket, the default one is Conscrypt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r861638619
##########
site2/docs/reference-configuration.md:
##########
@@ -379,6 +379,7 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size is greater
| brokerEntryMetadataInterceptors | Set broker entry metadata interceptors.<br /><br />Multiple interceptors should be separated by commas. <br /><br />Available values:<li>org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor</li><li>org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor</li> <br /><br />Example<br />brokerEntryMetadataInterceptors=org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor, org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor|N/A |
| enableExposingBrokerEntryMetadataToClient|Whether to expose broker entry metadata to client or not.<br /><br />Available values:<li>true</li><li>false</li><br />Example<br />enableExposingBrokerEntryMetadataToClient=true | false |
| strictBookieAffinityEnabled | Enable or disable the strict bookie isolation strategy. If enabled, <br /> - `bookie-ensemble` first tries to choose bookies that belong to a namespace's affinity group. If the number of bookies is not enough, then the rest bookies are chosen. <br /> - If namespace has no affinity group, `bookie-ensemble` only chooses bookies that belong to no region. If the number of bookies is not enough, `BKNotEnoughBookiesException` is thrown.| false |
+|managedCursorInfoCompressionType | The compression type of managed cursor information. <br />Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and `SNAPPY`). <br />If this value is `NONE` or invalid, managed cursor information is not compressed. | NONE
Review Comment:
```suggestion
|managedCursorInfoCompressionType | The compression type of managed cursor information. <br />Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and `SNAPPY`). <br />If this value is `NONE`, managed cursor information is not compressed. | NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#issuecomment-1101943987
@nodece @codelipenghui can you pls review this doc PR? Thanks.
CC @Anonymitaet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r861638993
##########
site2/docs/reference-configuration.md:
##########
@@ -710,6 +711,8 @@ You can set the log level and configuration in the [log4j2.yaml](https://github
|isAllowAutoUpdateSchemaEnabled|Allow schema to be auto updated at broker level.|true|
|schemaCompatibilityStrategy| The schema compatibility strategy at broker level, see [here](schema-evolution-compatibility.md#schema-compatibility-check-strategy) for available values.|FULL|
|systemTopicSchemaCompatibilityStrategy| The schema compatibility strategy is used for system topics, see [here](schema-evolution-compatibility.md#schema-compatibility-check-strategy) for available values.|ALWAYS_COMPATIBLE|
+|managedCursorInfoCompressionType | The compression type of managed cursor information. <br />Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and `SNAPPY`). <br />If this value is `NONE` or invalid, managed cursor information is not compressed. | NONE
Review Comment:
```suggestion
|managedCursorInfoCompressionType | The compression type of managed cursor information. <br />Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and `SNAPPY`). <br />If this value is `NONE`, managed cursor information is not compressed. | NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r873372716
##########
site2/docs/reference-configuration.md:
##########
@@ -810,6 +817,7 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tlsRequireTrustedClientCertOnConnect| Whether client certificates are required for TLS. Connections are rejected if the client certificate isn’t trusted. |false|
|tlsProtocols|Specify the tls protocols the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLSv1.3```, ```TLSv1.2``` ||
|tlsCiphers|Specify the tls cipher the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256```||
+|tlsProvider| The TLS provider for the broker service. <br />When TLS authentication with CACert is used, the valid value is either `OPENSSL` or `JDK`.<br />When TLS authentication with KeyStore is used, available options can be `SunJSSE`, `Conscrypt` and so on. | N/A
Review Comment:
Updated. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#issuecomment-1101944799
@momo-jun:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #15210: [feature][doc] Add configs for full-support tls provider and managed cursor compression
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #15210:
URL: https://github.com/apache/pulsar/pull/15210#discussion_r865657588
##########
site2/docs/reference-configuration.md:
##########
@@ -802,6 +809,7 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tlsRequireTrustedClientCertOnConnect| Whether client certificates are required for TLS. Connections are rejected if the client certificate isn’t trusted. |false|
|tlsProtocols|Specify the tls protocols the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLSv1.3```, ```TLSv1.2``` ||
|tlsCiphers|Specify the tls cipher the broker will use to negotiate during TLS Handshake. Multiple values can be specified, separated by commas. Example:- ```TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256```||
+|tlsProvider| The TLS provider for the broker service. <br />When TLS authentication with CACert is used, the valid value is either `OPENSSL` or `JDK`.<br />When TLS authentication with KeyStore is used, available options can be `SunJSSE`, `Conscrypt` and so on. | N/A
Review Comment:
@Technoboy- There's no problem here. This tlsProvider is only used to broker service, the web service requires the Conscrypt, we can config this by the `webserviceTlsProvider`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org