You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by ab...@apache.org on 2023/02/21 03:32:10 UTC
[druid] branch master updated: fix some intellij inspections in druid-processing (#13823)
This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 614205f3bc fix some intellij inspections in druid-processing (#13823)
614205f3bc is described below
commit 614205f3bcd366315432fe7bb12c9fdb7f68987c
Author: Clint Wylie <cw...@apache.org>
AuthorDate: Mon Feb 20 17:32:02 2023 -1000
fix some intellij inspections in druid-processing (#13823)
fix some intellij inspections in druid-processing
---
.../org/apache/druid/annotations/SuppressFBWarnings.java | 1 +
.../java/org/apache/druid/data/input/FirehoseFactory.java | 1 +
.../data/input/FirehoseFactoryToInputSourceAdaptor.java | 5 -----
.../main/java/org/apache/druid/data/input/InputFormat.java | 1 +
.../main/java/org/apache/druid/indexer/TaskLocation.java | 9 ---------
.../java/org/apache/druid/indexer/TaskMetricsGetter.java | 3 +++
.../apache/druid/java/util/common/DefineClassUtils.java | 5 -----
.../druid/java/util/common/HumanReadableBytesRange.java | 3 +++
.../java/org/apache/druid/java/util/common/Numbers.java | 10 +---------
.../org/apache/druid/java/util/common/StringUtils.java | 7 -------
.../util/common/guava/ParallelMergeCombiningSequence.java | 2 +-
.../java/org/apache/druid/java/util/common/io/Closer.java | 12 ------------
.../org/apache/druid/java/util/common/logger/Logger.java | 1 +
.../org/apache/druid/java/util/emitter/core/EventMap.java | 9 ---------
.../java/util/emitter/factory/HttpEmitterFactory.java | 2 +-
.../java/util/emitter/factory/LoggingEmitterFactory.java | 5 +----
.../java/util/emitter/factory/NoopEmitterFactory.java | 1 +
.../emitter/factory/ParametrizedUriEmitterFactory.java | 2 +-
.../druid/java/util/http/client/HttpClientProxyConfig.java | 1 +
.../java/util/http/client/response/FullResponseHolder.java | 1 +
.../apache/druid/java/util/metrics/AbstractMonitor.java | 1 +
.../org/apache/druid/java/util/metrics/PidDiscoverer.java | 1 +
.../org/apache/druid/java/util/metrics/ProcFsReader.java | 1 -
.../src/main/java/org/apache/druid/math/expr/ExprEval.java | 6 ------
.../BivariateDoubleFunctionVectorValueProcessor.java | 2 --
.../vector/BivariateFunctionVectorObjectProcessor.java | 3 ---
.../vector/BivariateLongFunctionVectorValueProcessor.java | 2 --
.../vector/LongOutObjectInFunctionVectorProcessor.java | 3 ---
.../vector/LongOutObjectsInFunctionVectorProcessor.java | 1 -
.../expr/vector/ObjectOutMultiObjectInVectorProcessor.java | 2 --
.../vector/ObjectOutObjectsInFunctionVectorProcessor.java | 1 -
.../UnivariateDoubleFunctionVectorValueProcessor.java | 2 --
.../vector/UnivariateFunctionVectorObjectProcessor.java | 2 --
.../vector/UnivariateLongFunctionVectorValueProcessor.java | 2 --
.../druid/metadata/PasswordProviderRedactionMixIn.java | 1 +
.../src/main/java/org/apache/druid/timeline/SegmentId.java | 14 --------------
.../partition/BuildingSingleDimensionShardSpec.java | 3 +++
.../druid/timeline/partition/SingleDimensionShardSpec.java | 1 +
.../main/java/org/apache/druid/utils/CircularBuffer.java | 1 +
.../src/main/java/org/apache/druid/utils/Runnables.java | 1 +
40 files changed, 27 insertions(+), 104 deletions(-)
diff --git a/processing/src/main/java/org/apache/druid/annotations/SuppressFBWarnings.java b/processing/src/main/java/org/apache/druid/annotations/SuppressFBWarnings.java
index fb1d5b1a12..f3e899d871 100644
--- a/processing/src/main/java/org/apache/druid/annotations/SuppressFBWarnings.java
+++ b/processing/src/main/java/org/apache/druid/annotations/SuppressFBWarnings.java
@@ -25,6 +25,7 @@ import java.lang.annotation.RetentionPolicy;
/**
* Annotation for suppressing spotbugs checks when necessary.
*/
+@SuppressWarnings("unused")
@Retention(RetentionPolicy.CLASS)
public @interface SuppressFBWarnings
{
diff --git a/processing/src/main/java/org/apache/druid/data/input/FirehoseFactory.java b/processing/src/main/java/org/apache/druid/data/input/FirehoseFactory.java
index 986d1d94a5..5561dc9337 100644
--- a/processing/src/main/java/org/apache/druid/data/input/FirehoseFactory.java
+++ b/processing/src/main/java/org/apache/druid/data/input/FirehoseFactory.java
@@ -86,6 +86,7 @@ public interface FirehoseFactory<T extends InputRowParser>
return connect(parser, temporaryDirectory);
}
+ @SuppressWarnings("unused")
@JsonIgnore
default boolean isSplittable()
{
diff --git a/processing/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java b/processing/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java
index 35322c2a0f..ca74798e96 100644
--- a/processing/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java
+++ b/processing/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java
@@ -45,11 +45,6 @@ public class FirehoseFactoryToInputSourceAdaptor extends AbstractInputSource imp
return firehoseFactory;
}
- public InputRowParser getInputRowParser()
- {
- return inputRowParser;
- }
-
@Override
public boolean isSplittable()
{
diff --git a/processing/src/main/java/org/apache/druid/data/input/InputFormat.java b/processing/src/main/java/org/apache/druid/data/input/InputFormat.java
index 4957bfb1e9..345b47ca3e 100644
--- a/processing/src/main/java/org/apache/druid/data/input/InputFormat.java
+++ b/processing/src/main/java/org/apache/druid/data/input/InputFormat.java
@@ -58,6 +58,7 @@ public interface InputFormat
* This method is not being used anywhere for now, but should be considered
* in {@link SplittableInputSource#createSplits} in the future.
*/
+ @SuppressWarnings("unused")
@JsonIgnore
boolean isSplittable();
diff --git a/processing/src/main/java/org/apache/druid/indexer/TaskLocation.java b/processing/src/main/java/org/apache/druid/indexer/TaskLocation.java
index 1cc83db4d8..fe8accd33d 100644
--- a/processing/src/main/java/org/apache/druid/indexer/TaskLocation.java
+++ b/processing/src/main/java/org/apache/druid/indexer/TaskLocation.java
@@ -21,7 +21,6 @@ package org.apache.druid.indexer;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
-import com.google.common.net.HostAndPort;
import org.apache.druid.java.util.common.IAE;
import javax.annotation.Nullable;
@@ -133,12 +132,4 @@ public class TaskLocation
{
return Objects.hash(host, port, tlsPort);
}
-
- public HostAndPort toHostAndPort()
- {
- if (tlsPort >= 0) {
- return HostAndPort.fromParts(host, tlsPort);
- }
- return HostAndPort.fromParts(host, port);
- }
}
diff --git a/processing/src/main/java/org/apache/druid/indexer/TaskMetricsGetter.java b/processing/src/main/java/org/apache/druid/indexer/TaskMetricsGetter.java
index e51e626fce..4498a3e56a 100644
--- a/processing/src/main/java/org/apache/druid/indexer/TaskMetricsGetter.java
+++ b/processing/src/main/java/org/apache/druid/indexer/TaskMetricsGetter.java
@@ -26,7 +26,10 @@ import java.util.Map;
public interface TaskMetricsGetter
{
+ @SuppressWarnings("unused")
List<String> getKeys();
+
+ @SuppressWarnings("unused")
@Nullable
Map<String, Number> getTotalMetrics();
}
diff --git a/processing/src/main/java/org/apache/druid/java/util/common/DefineClassUtils.java b/processing/src/main/java/org/apache/druid/java/util/common/DefineClassUtils.java
index dba354d12b..604ef98739 100644
--- a/processing/src/main/java/org/apache/druid/java/util/common/DefineClassUtils.java
+++ b/processing/src/main/java/org/apache/druid/java/util/common/DefineClassUtils.java
@@ -171,11 +171,6 @@ public class DefineClassUtils
return defineClass;
}
- static int getArrayLength(byte[] bytes)
- {
- return bytes.length;
- }
-
public static Class defineClass(
Class<?> targetClass,
byte[] byteCode,
diff --git a/processing/src/main/java/org/apache/druid/java/util/common/HumanReadableBytesRange.java b/processing/src/main/java/org/apache/druid/java/util/common/HumanReadableBytesRange.java
index 4d7fa37f78..644dae797d 100644
--- a/processing/src/main/java/org/apache/druid/java/util/common/HumanReadableBytesRange.java
+++ b/processing/src/main/java/org/apache/druid/java/util/common/HumanReadableBytesRange.java
@@ -47,6 +47,7 @@ import java.lang.annotation.Target;
@Target({ElementType.METHOD, ElementType.FIELD, ElementType.ANNOTATION_TYPE, ElementType.CONSTRUCTOR, ElementType.PARAMETER})
@Retention(RetentionPolicy.RUNTIME)
@Documented
+@SuppressWarnings("unused")
@Constraint(validatedBy = HumanReadableBytesRange.HumanReadableBytesRangeValidator.class)
public @interface HumanReadableBytesRange
{
@@ -66,9 +67,11 @@ public @interface HumanReadableBytesRange
//ConstraintValidator requires
String message() default "value must be in the range of [{min}, {max}]";
+
//ConstraintValidator requires
Class<? extends Payload>[] payload() default {};
+ @SuppressWarnings("unused")
class HumanReadableBytesRangeValidator implements ConstraintValidator<HumanReadableBytesRange, Object>
{
private HumanReadableBytesRange range;
diff --git a/processing/src/main/java/org/apache/druid/java/util/common/Numbers.java b/processing/src/main/java/org/apache/druid/java/util/common/Numbers.java
index d24d9799cc..06c988e8af 100644
--- a/processing/src/main/java/org/apache/druid/java/util/common/Numbers.java
+++ b/processing/src/main/java/org/apache/druid/java/util/common/Numbers.java
@@ -200,21 +200,13 @@ public final class Numbers
return lobj;
}
// try as a double, for "ddd.dd" , Longs.tryParse(..) returns null
- Double dobj = Doubles.tryParse((String) val);
+ Double dobj = Doubles.tryParse(val);
if (dobj != null) {
return dobj.longValue();
}
throw new NumberFormatException("Cannot parse string to long");
}
- public static int toIntExact(long value, String error)
- {
- if ((int) value != value) {
- throw new ArithmeticException(error);
- }
- return (int) value;
- }
-
private Numbers()
{
}
diff --git a/processing/src/main/java/org/apache/druid/java/util/common/StringUtils.java b/processing/src/main/java/org/apache/druid/java/util/common/StringUtils.java
index d130986501..e86d51b8d9 100644
--- a/processing/src/main/java/org/apache/druid/java/util/common/StringUtils.java
+++ b/processing/src/main/java/org/apache/druid/java/util/common/StringUtils.java
@@ -21,12 +21,10 @@ package org.apache.druid.java.util.common;
import com.google.common.base.Strings;
import it.unimi.dsi.fastutil.bytes.ByteArrayList;
-import it.unimi.dsi.fastutil.bytes.ByteList;
import org.apache.commons.io.IOUtils;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
-
import java.io.IOException;
import java.io.InputStream;
import java.io.UnsupportedEncodingException;
@@ -268,11 +266,6 @@ public class StringUtils
return StringUtils.fromUtf8(buffer.elements(), 0, buffer.size());
}
- public static String fromUtf8(final ByteList buffer)
- {
- return StringUtils.fromUtf8(buffer.toByteArray());
- }
-
/**
* If buffer is Decodes a UTF-8 string from the remaining bytes of a buffer.
* Advances the position of the buffer by {@link ByteBuffer#remaining()}.
diff --git a/processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java b/processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
index da79042406..b0b3d1d726 100644
--- a/processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
+++ b/processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
@@ -93,7 +93,7 @@ public class ParallelMergeCombiningSequence<T> extends YieldingSequenceBase<T>
BinaryOperator<T> combineFn,
boolean hasTimeout,
long timeoutMillis,
- int queryPriority,
+ @SuppressWarnings("unused") int queryPriority,
int parallelism,
int yieldAfter,
int batchSize,
diff --git a/processing/src/main/java/org/apache/druid/java/util/common/io/Closer.java b/processing/src/main/java/org/apache/druid/java/util/common/io/Closer.java
index c843f29b71..a366f6c3fa 100644
--- a/processing/src/main/java/org/apache/druid/java/util/common/io/Closer.java
+++ b/processing/src/main/java/org/apache/druid/java/util/common/io/Closer.java
@@ -130,18 +130,6 @@ public final class Closer implements Closeable
return closeable;
}
- /**
- * Registers a list of {@code Closeable} to be closed when this {@code Closer} is
- * {@linkplain #close closed}.
- *
- * @return the supplied list of {@code Closeable}
- */
- public <C extends Closeable> Iterable<C> registerAll(Iterable<C> closeables)
- {
- closeables.forEach(this::register);
- return closeables;
- }
-
/**
* Stores the given throwable and rethrows it. It will be rethrown as is if it is an
* {@code IOException}, {@code RuntimeException} or {@code Error}. Otherwise, it will be rethrown
diff --git a/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java b/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java
index 8306dcad9e..07f1cd1fba 100644
--- a/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java
+++ b/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java
@@ -63,6 +63,7 @@ public class Logger
return log;
}
+ @SuppressWarnings("unused")
@Override
public String toString()
{
diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/core/EventMap.java b/processing/src/main/java/org/apache/druid/java/util/emitter/core/EventMap.java
index 5cf031b2dc..50237eb023 100644
--- a/processing/src/main/java/org/apache/druid/java/util/emitter/core/EventMap.java
+++ b/processing/src/main/java/org/apache/druid/java/util/emitter/core/EventMap.java
@@ -79,15 +79,6 @@ public class EventMap extends HashMap<String, Object>
return this;
}
- /**
- * Adds map entry to the map
- */
- public Builder put(Map.Entry<String, Object> entry)
- {
- map.put(entry.getKey(), entry.getValue());
- return this;
- }
-
/**
* Adds all key -> value pairs from other map
*/
diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/HttpEmitterFactory.java b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/HttpEmitterFactory.java
index 53f5b7a9d6..e1811b8c90 100644
--- a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/HttpEmitterFactory.java
+++ b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/HttpEmitterFactory.java
@@ -26,9 +26,9 @@ import org.apache.druid.java.util.emitter.core.HttpEmitterConfig;
import org.apache.druid.java.util.emitter.core.HttpPostEmitter;
import org.asynchttpclient.AsyncHttpClient;
+@SuppressWarnings("unused")
public class HttpEmitterFactory extends HttpEmitterConfig implements EmitterFactory
{
-
@Override
public Emitter makeEmitter(ObjectMapper objectMapper, AsyncHttpClient httpClient, Lifecycle lifecycle)
{
diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/LoggingEmitterFactory.java b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/LoggingEmitterFactory.java
index 897787bee9..f5dac9e909 100644
--- a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/LoggingEmitterFactory.java
+++ b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/LoggingEmitterFactory.java
@@ -26,12 +26,9 @@ import org.apache.druid.java.util.emitter.core.LoggingEmitter;
import org.apache.druid.java.util.emitter.core.LoggingEmitterConfig;
import org.asynchttpclient.AsyncHttpClient;
+@SuppressWarnings("unused")
public class LoggingEmitterFactory extends LoggingEmitterConfig implements EmitterFactory
{
- public LoggingEmitterFactory()
- {
- }
-
@Override
public Emitter makeEmitter(ObjectMapper objectMapper, AsyncHttpClient httpClient, Lifecycle lifecycle)
{
diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/NoopEmitterFactory.java b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/NoopEmitterFactory.java
index db9bf60350..2067204d6c 100644
--- a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/NoopEmitterFactory.java
+++ b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/NoopEmitterFactory.java
@@ -25,6 +25,7 @@ import org.apache.druid.java.util.emitter.core.Emitter;
import org.apache.druid.java.util.emitter.core.NoopEmitter;
import org.asynchttpclient.AsyncHttpClient;
+@SuppressWarnings("unused")
public class NoopEmitterFactory implements EmitterFactory
{
@Override
diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/ParametrizedUriEmitterFactory.java b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/ParametrizedUriEmitterFactory.java
index 5f5670586e..9bf8537597 100644
--- a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/ParametrizedUriEmitterFactory.java
+++ b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/ParametrizedUriEmitterFactory.java
@@ -26,9 +26,9 @@ import org.apache.druid.java.util.emitter.core.ParametrizedUriEmitter;
import org.apache.druid.java.util.emitter.core.ParametrizedUriEmitterConfig;
import org.asynchttpclient.AsyncHttpClient;
+@SuppressWarnings("unused")
public class ParametrizedUriEmitterFactory extends ParametrizedUriEmitterConfig implements EmitterFactory
{
-
@Override
public Emitter makeEmitter(ObjectMapper objectMapper, AsyncHttpClient httpClient, Lifecycle lifecycle)
{
diff --git a/processing/src/main/java/org/apache/druid/java/util/http/client/HttpClientProxyConfig.java b/processing/src/main/java/org/apache/druid/java/util/http/client/HttpClientProxyConfig.java
index fec5c9e365..6a4a6dda8f 100644
--- a/processing/src/main/java/org/apache/druid/java/util/http/client/HttpClientProxyConfig.java
+++ b/processing/src/main/java/org/apache/druid/java/util/http/client/HttpClientProxyConfig.java
@@ -40,6 +40,7 @@ public class HttpClientProxyConfig
@JsonProperty("password")
private String password;
+ @SuppressWarnings("unused")
public HttpClientProxyConfig()
{
}
diff --git a/processing/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java b/processing/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java
index 27c2ed2512..e7242eb29c 100644
--- a/processing/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java
+++ b/processing/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java
@@ -49,5 +49,6 @@ public abstract class FullResponseHolder<T>
/**
* Get the data.
*/
+ @SuppressWarnings("unused")
public abstract T getContent();
}
diff --git a/processing/src/main/java/org/apache/druid/java/util/metrics/AbstractMonitor.java b/processing/src/main/java/org/apache/druid/java/util/metrics/AbstractMonitor.java
index 6e67bc0272..3fa5fc5c9c 100644
--- a/processing/src/main/java/org/apache/druid/java/util/metrics/AbstractMonitor.java
+++ b/processing/src/main/java/org/apache/druid/java/util/metrics/AbstractMonitor.java
@@ -41,6 +41,7 @@ public abstract class AbstractMonitor implements Monitor
started = false;
}
+ @SuppressWarnings("unused")
public boolean isStarted()
{
return started;
diff --git a/processing/src/main/java/org/apache/druid/java/util/metrics/PidDiscoverer.java b/processing/src/main/java/org/apache/druid/java/util/metrics/PidDiscoverer.java
index 7a21531058..4744b4ae57 100644
--- a/processing/src/main/java/org/apache/druid/java/util/metrics/PidDiscoverer.java
+++ b/processing/src/main/java/org/apache/druid/java/util/metrics/PidDiscoverer.java
@@ -21,5 +21,6 @@ package org.apache.druid.java.util.metrics;
public interface PidDiscoverer
{
+ @SuppressWarnings("unused")
long getPid();
}
diff --git a/processing/src/main/java/org/apache/druid/java/util/metrics/ProcFsReader.java b/processing/src/main/java/org/apache/druid/java/util/metrics/ProcFsReader.java
index 1a1ca08c7c..e8425448f6 100644
--- a/processing/src/main/java/org/apache/druid/java/util/metrics/ProcFsReader.java
+++ b/processing/src/main/java/org/apache/druid/java/util/metrics/ProcFsReader.java
@@ -38,7 +38,6 @@ public class ProcFsReader
private final File procDir;
private static final Logger LOG = new Logger(ProcFsReader.class);
- public static final Path DEFAULT_PROC_FS_ROOT = Paths.get("/proc/");
private static final String BOOT_ID_PATH = "sys/kernel/random/boot_id";
private static final String CPUINFO_PATH = "cpuinfo";
diff --git a/processing/src/main/java/org/apache/druid/math/expr/ExprEval.java b/processing/src/main/java/org/apache/druid/math/expr/ExprEval.java
index dbfc11d3c4..f06618a23a 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/ExprEval.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/ExprEval.java
@@ -1249,12 +1249,6 @@ public abstract class ExprEval<T>
return new ArrayExpr(arrayType, value);
}
- @Nullable
- public Object getIndex(int index)
- {
- return value == null ? null : value[index];
- }
-
protected boolean isScalar()
{
return value != null && value.length == 1;
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateDoubleFunctionVectorValueProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateDoubleFunctionVectorValueProcessor.java
index 904feb5d70..f23ee5aa38 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateDoubleFunctionVectorValueProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateDoubleFunctionVectorValueProcessor.java
@@ -34,7 +34,6 @@ public abstract class BivariateDoubleFunctionVectorValueProcessor<TLeftInput, TR
{
final ExprVectorProcessor<TLeftInput> left;
final ExprVectorProcessor<TRightInput> right;
- final int maxVectorSize;
final boolean[] outNulls;
final double[] outValues;
@@ -46,7 +45,6 @@ public abstract class BivariateDoubleFunctionVectorValueProcessor<TLeftInput, TR
{
this.left = left;
this.right = right;
- this.maxVectorSize = maxVectorSize;
this.outValues = new double[maxVectorSize];
this.outNulls = new boolean[maxVectorSize];
}
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateFunctionVectorObjectProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateFunctionVectorObjectProcessor.java
index 2f1279a6d2..2f7ae4f079 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateFunctionVectorObjectProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateFunctionVectorObjectProcessor.java
@@ -35,20 +35,17 @@ public abstract class BivariateFunctionVectorObjectProcessor<TLeftInput, TRightI
{
final ExprVectorProcessor<TLeftInput> left;
final ExprVectorProcessor<TRightInput> right;
- final int maxVectorSize;
final TOutput outValues;
final boolean sqlCompatible = NullHandling.sqlCompatible();
protected BivariateFunctionVectorObjectProcessor(
ExprVectorProcessor<TLeftInput> left,
ExprVectorProcessor<TRightInput> right,
- int maxVectorSize,
TOutput outValues
)
{
this.left = left;
this.right = right;
- this.maxVectorSize = maxVectorSize;
this.outValues = outValues;
}
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateLongFunctionVectorValueProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateLongFunctionVectorValueProcessor.java
index 243b7ae79b..fb68317bec 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateLongFunctionVectorValueProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateLongFunctionVectorValueProcessor.java
@@ -34,7 +34,6 @@ public abstract class BivariateLongFunctionVectorValueProcessor<TLeftInput, TRig
{
final ExprVectorProcessor<TLeftInput> left;
final ExprVectorProcessor<TRightInput> right;
- final int maxVectorSize;
final boolean[] outNulls;
final long[] outValues;
@@ -46,7 +45,6 @@ public abstract class BivariateLongFunctionVectorValueProcessor<TLeftInput, TRig
{
this.left = left;
this.right = right;
- this.maxVectorSize = maxVectorSize;
this.outValues = new long[maxVectorSize];
this.outNulls = new boolean[maxVectorSize];
}
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectInFunctionVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectInFunctionVectorProcessor.java
index 8ae0c4d751..7847d71ec2 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectInFunctionVectorProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectInFunctionVectorProcessor.java
@@ -27,8 +27,6 @@ import org.apache.druid.math.expr.ExpressionType;
public abstract class LongOutObjectInFunctionVectorProcessor
extends UnivariateFunctionVectorObjectProcessor<Object[], long[]>
{
- final ExpressionType inputType;
-
public LongOutObjectInFunctionVectorProcessor(
ExprVectorProcessor<Object[]> processor,
int maxVectorSize,
@@ -36,7 +34,6 @@ public abstract class LongOutObjectInFunctionVectorProcessor
)
{
super(CastToTypeVectorProcessor.cast(processor, inputType), maxVectorSize, new long[maxVectorSize]);
- this.inputType = inputType;
}
@Override
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectsInFunctionVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectsInFunctionVectorProcessor.java
index 88f2f0ff54..de34db9afd 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectsInFunctionVectorProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectsInFunctionVectorProcessor.java
@@ -38,7 +38,6 @@ public abstract class LongOutObjectsInFunctionVectorProcessor
super(
CastToTypeVectorProcessor.cast(left, inputType),
CastToTypeVectorProcessor.cast(right, inputType),
- maxVectorSize,
new long[maxVectorSize]
);
this.outNulls = new boolean[maxVectorSize];
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutMultiObjectInVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutMultiObjectInVectorProcessor.java
index 2a58e3ea82..0d668dc290 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutMultiObjectInVectorProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutMultiObjectInVectorProcessor.java
@@ -28,7 +28,6 @@ import org.apache.druid.math.expr.ExpressionType;
public abstract class ObjectOutMultiObjectInVectorProcessor implements ExprVectorProcessor<Object[]>
{
final ExprVectorProcessor<Object[]>[] inputs;
- final int maxVectorSize;
final Object[] outValues;
final ExpressionType expressionType;
@@ -40,7 +39,6 @@ public abstract class ObjectOutMultiObjectInVectorProcessor implements ExprVecto
)
{
this.inputs = inputs;
- this.maxVectorSize = maxVectorSize;
this.outValues = new Object[maxVectorSize];
this.expressionType = objectType;
}
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutObjectsInFunctionVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutObjectsInFunctionVectorProcessor.java
index 93089f5fc5..d64ffa3842 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutObjectsInFunctionVectorProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutObjectsInFunctionVectorProcessor.java
@@ -38,7 +38,6 @@ public abstract class ObjectOutObjectsInFunctionVectorProcessor
super(
CastToTypeVectorProcessor.cast(left, expressionType),
CastToTypeVectorProcessor.cast(right, expressionType),
- maxVectorSize,
new Object[maxVectorSize]
);
this.expressionType = expressionType;
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateDoubleFunctionVectorValueProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateDoubleFunctionVectorValueProcessor.java
index 03f9be1eb9..65ad076fea 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateDoubleFunctionVectorValueProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateDoubleFunctionVectorValueProcessor.java
@@ -32,7 +32,6 @@ import org.apache.druid.math.expr.Expr;
public abstract class UnivariateDoubleFunctionVectorValueProcessor<TInput> implements ExprVectorProcessor<double[]>
{
final ExprVectorProcessor<TInput> processor;
- final int maxVectorSize;
final boolean[] outNulls;
final double[] outValues;
@@ -42,7 +41,6 @@ public abstract class UnivariateDoubleFunctionVectorValueProcessor<TInput> imple
)
{
this.processor = processor;
- this.maxVectorSize = maxVectorSize;
this.outNulls = new boolean[maxVectorSize];
this.outValues = new double[maxVectorSize];
}
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorObjectProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorObjectProcessor.java
index 02fa6dd376..da9be989cf 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorObjectProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorObjectProcessor.java
@@ -28,7 +28,6 @@ import org.apache.druid.math.expr.Expr;
public abstract class UnivariateFunctionVectorObjectProcessor<TInput, TOutput> implements ExprVectorProcessor<TOutput>
{
final ExprVectorProcessor<TInput> processor;
- final int maxVectorSize;
final boolean[] outNulls;
final TOutput outValues;
@@ -39,7 +38,6 @@ public abstract class UnivariateFunctionVectorObjectProcessor<TInput, TOutput> i
)
{
this.processor = processor;
- this.maxVectorSize = maxVectorSize;
this.outNulls = new boolean[maxVectorSize];
this.outValues = outValues;
}
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateLongFunctionVectorValueProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateLongFunctionVectorValueProcessor.java
index 8694489450..d24a5e9f14 100644
--- a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateLongFunctionVectorValueProcessor.java
+++ b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateLongFunctionVectorValueProcessor.java
@@ -32,7 +32,6 @@ import org.apache.druid.math.expr.Expr;
public abstract class UnivariateLongFunctionVectorValueProcessor<TInput> implements ExprVectorProcessor<long[]>
{
final ExprVectorProcessor<TInput> processor;
- final int maxVectorSize;
final boolean[] outNulls;
final long[] outValues;
@@ -42,7 +41,6 @@ public abstract class UnivariateLongFunctionVectorValueProcessor<TInput> impleme
)
{
this.processor = processor;
- this.maxVectorSize = maxVectorSize;
this.outNulls = new boolean[maxVectorSize];
this.outValues = new long[maxVectorSize];
}
diff --git a/processing/src/main/java/org/apache/druid/metadata/PasswordProviderRedactionMixIn.java b/processing/src/main/java/org/apache/druid/metadata/PasswordProviderRedactionMixIn.java
index 37a5b9a48f..5a96decb79 100644
--- a/processing/src/main/java/org/apache/druid/metadata/PasswordProviderRedactionMixIn.java
+++ b/processing/src/main/java/org/apache/druid/metadata/PasswordProviderRedactionMixIn.java
@@ -28,6 +28,7 @@ import com.fasterxml.jackson.annotation.JsonIgnore;
*/
public interface PasswordProviderRedactionMixIn
{
+ @SuppressWarnings("unused")
@JsonIgnore
String getPassword();
}
diff --git a/processing/src/main/java/org/apache/druid/timeline/SegmentId.java b/processing/src/main/java/org/apache/druid/timeline/SegmentId.java
index 986d9aafe2..99d17c4405 100644
--- a/processing/src/main/java/org/apache/druid/timeline/SegmentId.java
+++ b/processing/src/main/java/org/apache/druid/timeline/SegmentId.java
@@ -29,7 +29,6 @@ import com.google.common.collect.Iterables;
import com.google.common.primitives.Ints;
import org.apache.druid.guice.annotations.PublicApi;
import org.apache.druid.java.util.common.DateTimes;
-import org.apache.druid.java.util.common.IAE;
import org.apache.druid.java.util.common.Intervals;
import org.apache.druid.query.SegmentDescriptor;
import org.apache.druid.timeline.partition.ShardSpec;
@@ -41,7 +40,6 @@ import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
-import java.util.function.Function;
import java.util.regex.Matcher;
import java.util.stream.IntStream;
@@ -233,18 +231,6 @@ public final class SegmentId implements Comparable<SegmentId>
}
}
- public static Function<String, Interval> makeIntervalExtractor(final String dataSource)
- {
- return identifier -> {
- SegmentId segmentIdentifierParts = tryParse(dataSource, identifier);
- if (segmentIdentifierParts == null) {
- throw new IAE("Invalid identifier [%s]", identifier);
- }
-
- return segmentIdentifierParts.getInterval();
- };
- }
-
/**
* Creates a dummy SegmentId with the given data source. This method is useful in benchmark and test code.
*/
diff --git a/processing/src/main/java/org/apache/druid/timeline/partition/BuildingSingleDimensionShardSpec.java b/processing/src/main/java/org/apache/druid/timeline/partition/BuildingSingleDimensionShardSpec.java
index ff7d5b9ba8..8bc12de40f 100644
--- a/processing/src/main/java/org/apache/druid/timeline/partition/BuildingSingleDimensionShardSpec.java
+++ b/processing/src/main/java/org/apache/druid/timeline/partition/BuildingSingleDimensionShardSpec.java
@@ -79,17 +79,20 @@ public class BuildingSingleDimensionShardSpec extends BuildingDimensionRangeShar
return jsonMap;
}
+ @SuppressWarnings("unused")
public String getDimension()
{
return dimension;
}
+ @SuppressWarnings("unused")
@Nullable
public String getStart()
{
return start;
}
+ @SuppressWarnings("unused")
@Nullable
public String getEnd()
{
diff --git a/processing/src/main/java/org/apache/druid/timeline/partition/SingleDimensionShardSpec.java b/processing/src/main/java/org/apache/druid/timeline/partition/SingleDimensionShardSpec.java
index a8ebbe8dfc..59ef1be3d6 100644
--- a/processing/src/main/java/org/apache/druid/timeline/partition/SingleDimensionShardSpec.java
+++ b/processing/src/main/java/org/apache/druid/timeline/partition/SingleDimensionShardSpec.java
@@ -93,6 +93,7 @@ public class SingleDimensionShardSpec extends DimensionRangeShardSpec
return jsonMap;
}
+ @SuppressWarnings("unused")
public String getDimension()
{
return dimension;
diff --git a/processing/src/main/java/org/apache/druid/utils/CircularBuffer.java b/processing/src/main/java/org/apache/druid/utils/CircularBuffer.java
index b61149a012..ba1299ade8 100644
--- a/processing/src/main/java/org/apache/druid/utils/CircularBuffer.java
+++ b/processing/src/main/java/org/apache/druid/utils/CircularBuffer.java
@@ -28,6 +28,7 @@ import com.google.common.base.Preconditions;
*/
public class CircularBuffer<E>
{
+ @SuppressWarnings("unused")
public E[] getBuffer()
{
return buffer;
diff --git a/processing/src/main/java/org/apache/druid/utils/Runnables.java b/processing/src/main/java/org/apache/druid/utils/Runnables.java
index 8cb57df631..a4bf36fc91 100644
--- a/processing/src/main/java/org/apache/druid/utils/Runnables.java
+++ b/processing/src/main/java/org/apache/druid/utils/Runnables.java
@@ -26,6 +26,7 @@ import org.apache.druid.guice.annotations.PublicApi;
@PublicApi
public class Runnables
{
+ @SuppressWarnings("unused")
public static Runnable getNoopRunnable()
{
return () -> {};
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org