You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "ro-ket (GitHub)" <gi...@apache.org> on 2018/08/25 01:45:29 UTC

[GitHub] [ambari] ro-ket opened pull request #2169: AMBARI-24538: OneFS mpack quicklinks require port, https

## What changes were proposed in this pull request?

Modify the OneFS management pack for Ambari. Add port to url, define port, and switch protocol to https.

## How was this patch tested?

This patch was tested manually by changing `/var/lib/ambari-server/resources/mpacks/onefs-ambari-mpack-0.1/addon-services/ONEFS/1.0.0/quicklinks/quicklinks.json`, doing `ambari-server restart` and confirming that the links appear correctly in Ambari. Then the links were followed after enabling http file browse on OneFS and after setting OneFS back to http redirect (to adminstration ui).

[ Full content available at: https://github.com/apache/ambari/pull/2169 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [ambari] asfgit commented on issue #2169: AMBARI-24538: OneFS mpack quicklinks require port, https

Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3751/
Test PASSed.


[ Full content available at: https://github.com/apache/ambari/pull/2169 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [ambari] asfgit commented on issue #2169: AMBARI-24538: OneFS mpack quicklinks require port, https

Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3743/
Test FAILed.
Test FAILured.


[ Full content available at: https://github.com/apache/ambari/pull/2169 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [ambari] ro-ket commented on pull request #2169: AMBARI-24538: OneFS mpack quicklinks require port, https

Posted by "ro-ket (GitHub)" <gi...@apache.org>.
No. `80` points to:
* file browse when http service is `enabled`
* nothing when http service is `disabled`
* webui only when http service is `redirect` (the default value in OneFS; and since not indicating a port on a http query default to 80, that's why this worked most of the time)

`8080` is the safe port.

[ Full content available at: https://github.com/apache/ambari/pull/2169 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [ambari] zeroflag commented on issue #2169: AMBARI-24538: OneFS mpack quicklinks require port, https

Posted by "zeroflag (GitHub)" <gi...@apache.org>.
retest this please

[ Full content available at: https://github.com/apache/ambari/pull/2169 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [ambari] zeroflag closed pull request #2169: AMBARI-24538: OneFS mpack quicklinks require port, https

Posted by "zeroflag (GitHub)" <gi...@apache.org>.
[ pull request closed by zeroflag ]

[ Full content available at: https://github.com/apache/ambari/pull/2169 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [ambari] dmtucker commented on pull request #2169: AMBARI-24538: OneFS mpack quicklinks require port, https

Posted by "dmtucker (GitHub)" <gi...@apache.org>.
Should this (below too) be `80` (or maybe `8082`)?

[ Full content available at: https://github.com/apache/ambari/pull/2169 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [ambari] ro-ket commented on pull request #2169: AMBARI-24538: OneFS mpack quicklinks require port, https

Posted by "ro-ket (GitHub)" <gi...@apache.org>.
No. `80` points to:
* file browse when http service is `enabled`
* nothing when http service is `disabled`
* webui only when http service is `redirect` (the default value in OneFS; and since not indicating a port on an http query defaults to 80, that's why this worked most of the time)

`8080` is the safe port.

[ Full content available at: https://github.com/apache/ambari/pull/2169 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org