[GitHub] [flink] TisonKun opened a new pull request #10182: [FLINK-14761][sql-client] Fix ProgramDeployer#deployJobOnNewCluster potentially leak cluster

[GitBox <gi...@apache.org>]

TisonKun opened a new pull request #10182: [FLINK-14761][sql-client] Fix ProgramDeployer#deployJobOnNewCluster potentially leak cluster
URL: https://github.com/apache/flink/pull/10182
 
 
   ## What is the purpose of the change
   
   Currently `ProgramDeployer#deployJobOnNewCluster` always deploys cluster in attached mode. If `awaitJobResult == false` the cluster won't be closed because `Dispatcher` wait for delivering the result.
   
   
   ## Brief change log
   
   - decide detach/attach based on whether or not `awaitJobResult`.
   - clean up code path.
   
   
   ## Verifying this change
   
   I think we lost test coverage on this module. Could it be a follow up we generally add a test suite?
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services