[GitHub] [spark] ivoson commented on a change in pull request #33905: [SPARK-36658][SQL] Expose execution id to QueryExecutionListener

[GitBox <gi...@apache.org>]

ivoson commented on a change in pull request #33905:
URL: https://github.com/apache/spark/pull/33905#discussion_r703271980



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Observation.scala
##########
@@ -150,10 +150,12 @@ class Observation(name: String) {
 private[sql] case class ObservationListener(observation: Observation)
   extends QueryExecutionListener {
 
-  override def onSuccess(funcName: String, qe: QueryExecution, durationNs: Long): Unit =
+  override def onSuccess(
+      funcName: String, executionId: Long, qe: QueryExecution, durationNs: Long): Unit =

Review comment:
       Yes, they are not the same. Definitely, it will great if we can unify these.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org