You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/24 18:30:42 UTC

[GitHub] [beam] ibzib commented on a change in pull request #12040: Revert "Fix state handler for missing service descriptor."

ibzib commented on a change in pull request #12040:
URL: https://github.com/apache/beam/pull/12040#discussion_r445090535



##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -688,7 +688,7 @@ def __init__(self, state_cache, credentials=None):
 
   def create_state_handler(self, api_service_descriptor):
     # type: (endpoints_pb2.ApiServiceDescriptor) -> CachingStateHandler
-    if api_service_descriptor == endpoints_pb2.ApiServiceDescriptor():
+    if not api_service_descriptor:

Review comment:
       I'll do that in a follow-up so it's easier to test.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org