You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/10 14:55:12 UTC
[GitHub] [pulsar] bithavoc opened a new pull request #9555: [Issue 290][docs] Fix outdated docker-compose advertised address
bithavoc opened a new pull request #9555:
URL: https://github.com/apache/pulsar/pull/9555
Fixes #4044, completes #290
### Motivation
When you google "docker compose pulsar", the first results points to `docker-compose/standalone-dashboard/docker-compose.yml` which works for the most part if you use CLI commands such as `pulsar-admin`, but the dashboard never shows any tenant, topics, etc. This has been reported in issues such as #4044 and officially given a recommendation in #290, however, `docker-compose/standalone-dashboard/docker-compose.yml` is still outdated.
### Modifications
- Modified `docker-compose/standalone-dashboard/docker-compose.yml` to include `--advertised-address` with the name of the network host inside the docker-compose network that the dashboard can actually use.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change added tests and can be verified as follows:
- without applying this patch, run `docker-compose up`, even after 2 minutes the dashboard still doesn't show tenants or topics
- apply the patch and then run `docker-compose up`, refresh the dashboard UI after 20 seconds and the tenants and topics show up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bithavoc commented on pull request #9555: [Issue 4044][docs] Fix outdated docker-compose advertised address
Posted by GitBox <gi...@apache.org>.
bithavoc commented on pull request #9555:
URL: https://github.com/apache/pulsar/pull/9555#issuecomment-777158780
@sijie I see this PR is assigned to me but I'm having a hard time what's the next step from my side, I'm looking at the CONTRIBUTING guide and it states:
> Commit: Once at least 2 Pulsar committers have approved the pull request, a Pulsar committer will merge it into the master branch (and potentially backport to stable branches in case of bug fixes).
So I guess I need another commiter to approve? Also the CI is complaining about something but I can't really tell what's the issue is, I can't seem retry the action either and the action step doesn't load the log output(somehow private?).
It's my first contribution to the project, can you give me some clues on how to proceed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #9555: [Issue 4044][docs] Fix outdated docker-compose advertised address
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #9555:
URL: https://github.com/apache/pulsar/pull/9555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9555: [Issue 4044][docs] Fix outdated docker-compose advertised address
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9555:
URL: https://github.com/apache/pulsar/pull/9555#issuecomment-777182894
@bithavoc I assigned it to you to grant the contribution credit to you. We probably just need approval from another committer and then we can merge this pull request.
The CI failures are not unexpected. There is some flakiness on the CI. I will rerun those CI tests. You don't need to worry about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org