[jira] [Commented] (TINKERPOP-1256) Remove Traverser.split(R r, Step step)

["pieter martin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232617#comment-15232617 ] 

pieter martin commented on TINKERPOP-1256:
------------------------------------------

+1

> Remove Traverser.split(R r, Step<T,R> step)
> -------------------------------------------
>
>                 Key: TINKERPOP-1256
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1256
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.0-incubating
>            Reporter: Marko A. Rodriguez
>
> I just noticed that {{Traverser.split(R r, Step<T,R> step)}} has no implementation that actually uses the {{step}} argument. This is an appendage from back in the day when it was always guaranteed that the step would set labels and stepId. This is not the case with many OLAP variations of a step.
> I think we should do the following.
> 1. Figure out how to get rid of {{privat e AbstractStep.prepareTraversalForNextStep()}} as this is an blemish.
> 2. Create {{Traverser.split(R r)}}.
> 3. Then labels are added via {{traverser.setPath(traverser.getPath().extend(labels))}}.
> Not a big ticket item, just some nice backwards compatible house-cleaning to remove technical debt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)