You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/05 20:16:53 UTC

[GitHub] [flink] vahmed-hamdy opened a new pull request, #19877: [FLINK-27756] Setting Batches sent to 1 and extending sending margin in checkLoggedSendTimesAreWithinBounds test

vahmed-hamdy opened a new pull request, #19877:
URL: https://github.com/apache/flink/pull/19877

<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*

*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*

## Contribution Checklist

- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.

- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.

- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).

- Each pull request should address only one issue, not mix up code from multiple issues.

- Each commit in the pull request has a meaningful commit message (including the JIRA id)

- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

## What is the purpose of the change

- One of the integration tests (checkLoggedSendTimesAreWithinBounds) of AsyncSinkWriterTest has been reported to fail intermittently on build pipeline causing blocking of new changes.

- The failing test tests sending times for batch with a tight margin and using multiple batches, hence the test was unstable and was changed.

## Brief change log

- updated `checkLoggedSendTimesAreWithinBounds` test to be with 20ms time margin and to send 1 single batch.

This change added tests and can be verified as follows:

- success rate of test up from 98% to 100%.

## Does this pull request potentially affect one of the following parts:

- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no

## Documentation

- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dannycranmer merged pull request #19877: [FLINK-27756] Setting Batches sent to 1 and extending sending margin in checkLoggedSendTimesAreWithinBounds test

Posted by GitBox <gi...@apache.org>.

dannycranmer merged PR #19877:
URL: https://github.com/apache/flink/pull/19877


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] CrynetLogistics commented on pull request #19877: [FLINK-27756] Setting Batches sent to 1 and extending sending margin in checkLoggedSendTimesAreWithinBounds test

Posted by GitBox <gi...@apache.org>.

CrynetLogistics commented on PR #19877:
URL: https://github.com/apache/flink/pull/19877#issuecomment-1150869575

   Thanks for posting your findings in the JIRA, I concur with the solution. Thank you for making this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19877: [FLINK-27756] Setting Batches sent to 1 and extending sending margin in checkLoggedSendTimesAreWithinBounds test

Posted by GitBox <gi...@apache.org>.

flinkbot commented on PR #19877:
URL: https://github.com/apache/flink/pull/19877#issuecomment-1146877498

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e1f9c45ebf1af2e72d76b67297b4fa97e96e0ddc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e1f9c45ebf1af2e72d76b67297b4fa97e96e0ddc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e1f9c45ebf1af2e72d76b67297b4fa97e96e0ddc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] vahmed-hamdy commented on pull request #19877: [FLINK-27756] Setting Batches sent to 1 and extending sending margin in checkLoggedSendTimesAreWithinBounds test

Posted by GitBox <gi...@apache.org>.

vahmed-hamdy commented on PR #19877:
URL: https://github.com/apache/flink/pull/19877#issuecomment-1149646838

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org