Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

["cpoerschke (via GitHub)" <gi...@apache.org>]

cpoerschke commented on code in PR #2632:
URL: https://github.com/apache/solr/pull/2632#discussion_r1928413086


##########
solr/core/src/java/org/apache/solr/search/facet/MissingAgg.java:
##########
@@ -45,7 +45,7 @@ public SlotAcc createSlotAcc(FacetContext fcontext, long numDocs, int numSlots)
       if (sf.multiValued() || sf.getType().multiValuedFieldCache()) {
         Query query = null;
         if (sf.hasDocValues()) {
-          query = new DocValuesFieldExistsQuery(sf.getName());
+          query = new FieldExistsQuery(sf.getName());

Review Comment:
   > I suspect this code pre-dated FieldType.getExistenceQuery -- just call that.
   
   ```suggestion
             query = sf.getType().getExistenceQuery(null, sf);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org