You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/27 16:16:21 UTC

[GitHub] [beam] ahmedabu98 commented on pull request #21867: Beam 12994 - Python SDK BigQuery - Promote `schemaUpdateOptions` to named arguments

ahmedabu98 commented on PR #21867:
URL: https://github.com/apache/beam/pull/21867#issuecomment-1196967689

   Agree with @johnjcasey that we need an integration test for this change, specifically to make sure that both `additional_load_parameters` and `schema_update_options` are viable. I would be happy to review that test.
   
   @waltage we have a few BQ tests in [apache_beam/io/gcp](https://github.com/apache/beam/tree/master/sdks/python/apache_beam/io/gcp). This is an [example test](https://github.com/apache/beam/blob/82384a462a04c046723d8dcd8377373ecc5767d4/sdks/python/apache_beam/io/gcp/bigquery_test.py#L1774-L1842) that uses [`BigQueryTableMatcher`](https://github.com/apache/beam/blob/c36f54486a5185fd11bc34186a688e9b7abfa4b5/sdks/python/apache_beam/io/gcp/tests/bigquery_matcher.py#L207) to test for options in `additional_bq_parameters`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org