You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Cheolsoo Park <ch...@cloudera.com> on 2012/11/19 06:32:09 UTC
Review Request: PIG-2924 PigStats should not be assuming all Storage classes
to be file-based storage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8122/
-----------------------------------------------------------
Review request for pig, Santhosh Srinivasan and Bill Graham.
Description
-------
Please see:
https://issues.apache.org/jira/browse/PIG-2924
This addresses bug PIG-2924.
https://issues.apache.org/jira/browse/PIG-2924
Diffs
-----
conf/pig.properties a453940
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/FileBasedOutputSizeReader.java e69de29
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigStatsOutputSizeReader.java e69de29
src/org/apache/pig/tools/pigstats/JobStats.java fca29d7
test/org/apache/pig/test/TestJobStats.java 42926bc
Diff: https://reviews.apache.org/r/8122/diff/
Testing
-------
ant test -Dhadoopversion=20/23
Thanks,
Cheolsoo Park
Re: Review Request: PIG-2924 PigStats should not be assuming all Storage
classes to be file-based storage
Posted by Cheolsoo Park <ch...@cloudera.com>.
> On Nov. 19, 2012, 6:18 a.m., Bill Graham wrote:
> > LGTM, sorry for the delay with the review.
Thank you, sir!
- Cheolsoo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8122/#review13551
-----------------------------------------------------------
On Nov. 19, 2012, 5:32 a.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8122/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 5:32 a.m.)
>
>
> Review request for pig, Santhosh Srinivasan and Bill Graham.
>
>
> Description
> -------
>
> Please see:
> https://issues.apache.org/jira/browse/PIG-2924
>
>
> This addresses bug PIG-2924.
> https://issues.apache.org/jira/browse/PIG-2924
>
>
> Diffs
> -----
>
> conf/pig.properties a453940
> src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/FileBasedOutputSizeReader.java e69de29
> src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigStatsOutputSizeReader.java e69de29
> src/org/apache/pig/tools/pigstats/JobStats.java fca29d7
> test/org/apache/pig/test/TestJobStats.java 42926bc
>
> Diff: https://reviews.apache.org/r/8122/diff/
>
>
> Testing
> -------
>
> ant test -Dhadoopversion=20/23
>
>
> Thanks,
>
> Cheolsoo Park
>
>
Re: Review Request: PIG-2924 PigStats should not be assuming all Storage
classes to be file-based storage
Posted by Bill Graham <bi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8122/#review13551
-----------------------------------------------------------
Ship it!
LGTM, sorry for the delay with the review.
- Bill Graham
On Nov. 19, 2012, 5:32 a.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8122/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 5:32 a.m.)
>
>
> Review request for pig, Santhosh Srinivasan and Bill Graham.
>
>
> Description
> -------
>
> Please see:
> https://issues.apache.org/jira/browse/PIG-2924
>
>
> This addresses bug PIG-2924.
> https://issues.apache.org/jira/browse/PIG-2924
>
>
> Diffs
> -----
>
> conf/pig.properties a453940
> src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/FileBasedOutputSizeReader.java e69de29
> src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigStatsOutputSizeReader.java e69de29
> src/org/apache/pig/tools/pigstats/JobStats.java fca29d7
> test/org/apache/pig/test/TestJobStats.java 42926bc
>
> Diff: https://reviews.apache.org/r/8122/diff/
>
>
> Testing
> -------
>
> ant test -Dhadoopversion=20/23
>
>
> Thanks,
>
> Cheolsoo Park
>
>