You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/29 16:41:54 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #10191: feat: add configuration for Presto cursor poll interval
etr2460 opened a new pull request #10191:
URL: https://github.com/apache/incubator-superset/pull/10191
### SUMMARY
Uses the poll interval defined in the database's `connect_args` (if there) to set the polling interval for Presto's cursor. This will align the polling between Superset and PyHive, hopefully resulting in less downtime on shorter/synchronous queries (if the admin chooses)
### TEST PLAN
CI, unfortunately this is pretty hard to write a unit test for :/
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #10139
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @john-bodley @villebro @bkyryliuk @tooptoop4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10191: feat: add configuration for Presto cursor poll interval
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10191:
URL: https://github.com/apache/incubator-superset/pull/10191#discussion_r447157656
##########
File path: superset/db_engine_specs/presto.py
##########
@@ -729,6 +732,11 @@ def get_create_view(
def handle_cursor(cls, cursor: Any, query: Query, session: Session) -> None:
"""Updates progress information"""
query_id = query.id
+ poll_interval = (
+ query.database.get_extra()
Review comment:
it would be nice to add a property `connect_args` to the db object as this code becomes a bit repetitive:
https://github.com/apache/incubator-superset/search?q=connect_args&unscoped_q=connect_args
and by the way connect args should be part of the engine_params
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org