You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2012/02/27 23:26:30 UTC
broken unit tests on 0.8 branch
Hi Prashanth and Jun,
I checked out the latest 0.8 branch, and found that the
PrimitiveApiTest hangs on every run. The last known good revision that
I was tracking was 1239937. From svn, looks like the last few checkins
were your patches -
nnarkhed-ld:kafka-239-topic-metadata nnarkhed$ svn log -l 5
------------------------------------------------------------------------
r1244650 | junrao | 2012-02-15 11:08:08 -0800 (Wed, 15 Feb 2012) | 1 line
disable dup topic in consumer request; patched by Prashanth Menon;
reviewed by Jun Rao; KAFKA-240
------------------------------------------------------------------------
r1243407 | junrao | 2012-02-12 19:58:37 -0800 (Sun, 12 Feb 2012) | 1 line
new consumer request format; patched by Prashanth Menon; reviewed by
Jun Rao and Jay Kreps; KAFKA-240
------------------------------------------------------------------------
r1241754 | junrao | 2012-02-07 18:59:54 -0800 (Tue, 07 Feb 2012) | 1 line
refactor the async producer; patched by Jun Rao; reviewed by Neha
Narkhede; KAFKA-253
------------------------------------------------------------------------
r1239937 | nehanarkhede | 2012-02-02 15:40:39 -0800 (Thu, 02 Feb 2012) | 1 line
Merging commits 1230840:1239902 from trunk
------------------------------------------------------------------------
r1235492 | nehanarkhede | 2012-01-24 12:54:11 -0800 (Tue, 24 Jan 2012) | 1 line
Would you mind taking a look and stabilizing the branch, this is
blocking the patch on kafka-239.
Thanks,
Neha
Re: broken unit tests on 0.8 branch
Posted by Prashanth Menon <pr...@gmail.com>.
Definitely peculiar. I don't see, nor have I ever seen on 0.8, any hangs
locally on any of the tests. I can take a second look at the test when I
get a chance but am inclined to agree with Jun on it being a timing issue.
As to why only the Java side fails, well that's the interesting part.
On Feb 27, 2012 6:17 PM, "Jun Rao" <ju...@gmail.com> wrote:
> Seems like a transient failure. I only see javaapi.PrimitiveApiTest failure
> occasionally. Once we have the producer ack in place, we should be able to
> remove some of the timing dependencies that are likely to have caused the
> test failure.
>
> Thanks,
>
> Jun
>
> On Mon, Feb 27, 2012 at 2:57 PM, Neha Narkhede <neha.narkhede@gmail.com
> >wrote:
>
> > I think I should've mentioned that
> > kafka.javaapi.integration.PrimitiveApiTest fails, but not
> > kafka.integration.PrimitveApiTest.
> >
> > Thanks,
> > Neha
> >
> > On Mon, Feb 27, 2012 at 2:26 PM, Neha Narkhede <ne...@gmail.com>
> > wrote:
> > > Hi Prashanth and Jun,
> > >
> > > I checked out the latest 0.8 branch, and found that the
> > > PrimitiveApiTest hangs on every run. The last known good revision that
> > > I was tracking was 1239937. From svn, looks like the last few checkins
> > > were your patches -
> > >
> > >
> > > nnarkhed-ld:kafka-239-topic-metadata nnarkhed$ svn log -l 5
> > >
> ------------------------------------------------------------------------
> > > r1244650 | junrao | 2012-02-15 11:08:08 -0800 (Wed, 15 Feb 2012) | 1
> line
> > >
> > > disable dup topic in consumer request; patched by Prashanth Menon;
> > > reviewed by Jun Rao; KAFKA-240
> > >
> ------------------------------------------------------------------------
> > > r1243407 | junrao | 2012-02-12 19:58:37 -0800 (Sun, 12 Feb 2012) | 1
> line
> > >
> > > new consumer request format; patched by Prashanth Menon; reviewed by
> > > Jun Rao and Jay Kreps; KAFKA-240
> > >
> ------------------------------------------------------------------------
> > > r1241754 | junrao | 2012-02-07 18:59:54 -0800 (Tue, 07 Feb 2012) | 1
> line
> > >
> > > refactor the async producer; patched by Jun Rao; reviewed by Neha
> > > Narkhede; KAFKA-253
> > >
> ------------------------------------------------------------------------
> > > r1239937 | nehanarkhede | 2012-02-02 15:40:39 -0800 (Thu, 02 Feb 2012)
> |
> > 1 line
> > >
> > > Merging commits 1230840:1239902 from trunk
> > >
> ------------------------------------------------------------------------
> > > r1235492 | nehanarkhede | 2012-01-24 12:54:11 -0800 (Tue, 24 Jan 2012)
> |
> > 1 line
> > >
> > >
> > > Would you mind taking a look and stabilizing the branch, this is
> > > blocking the patch on kafka-239.
> > >
> > > Thanks,
> > > Neha
> >
>
Re: broken unit tests on 0.8 branch
Posted by Jun Rao <ju...@gmail.com>.
Seems like a transient failure. I only see javaapi.PrimitiveApiTest failure
occasionally. Once we have the producer ack in place, we should be able to
remove some of the timing dependencies that are likely to have caused the
test failure.
Thanks,
Jun
On Mon, Feb 27, 2012 at 2:57 PM, Neha Narkhede <ne...@gmail.com>wrote:
> I think I should've mentioned that
> kafka.javaapi.integration.PrimitiveApiTest fails, but not
> kafka.integration.PrimitveApiTest.
>
> Thanks,
> Neha
>
> On Mon, Feb 27, 2012 at 2:26 PM, Neha Narkhede <ne...@gmail.com>
> wrote:
> > Hi Prashanth and Jun,
> >
> > I checked out the latest 0.8 branch, and found that the
> > PrimitiveApiTest hangs on every run. The last known good revision that
> > I was tracking was 1239937. From svn, looks like the last few checkins
> > were your patches -
> >
> >
> > nnarkhed-ld:kafka-239-topic-metadata nnarkhed$ svn log -l 5
> > ------------------------------------------------------------------------
> > r1244650 | junrao | 2012-02-15 11:08:08 -0800 (Wed, 15 Feb 2012) | 1 line
> >
> > disable dup topic in consumer request; patched by Prashanth Menon;
> > reviewed by Jun Rao; KAFKA-240
> > ------------------------------------------------------------------------
> > r1243407 | junrao | 2012-02-12 19:58:37 -0800 (Sun, 12 Feb 2012) | 1 line
> >
> > new consumer request format; patched by Prashanth Menon; reviewed by
> > Jun Rao and Jay Kreps; KAFKA-240
> > ------------------------------------------------------------------------
> > r1241754 | junrao | 2012-02-07 18:59:54 -0800 (Tue, 07 Feb 2012) | 1 line
> >
> > refactor the async producer; patched by Jun Rao; reviewed by Neha
> > Narkhede; KAFKA-253
> > ------------------------------------------------------------------------
> > r1239937 | nehanarkhede | 2012-02-02 15:40:39 -0800 (Thu, 02 Feb 2012) |
> 1 line
> >
> > Merging commits 1230840:1239902 from trunk
> > ------------------------------------------------------------------------
> > r1235492 | nehanarkhede | 2012-01-24 12:54:11 -0800 (Tue, 24 Jan 2012) |
> 1 line
> >
> >
> > Would you mind taking a look and stabilizing the branch, this is
> > blocking the patch on kafka-239.
> >
> > Thanks,
> > Neha
>
Re: broken unit tests on 0.8 branch
Posted by Neha Narkhede <ne...@gmail.com>.
I think I should've mentioned that
kafka.javaapi.integration.PrimitiveApiTest fails, but not
kafka.integration.PrimitveApiTest.
Thanks,
Neha
On Mon, Feb 27, 2012 at 2:26 PM, Neha Narkhede <ne...@gmail.com> wrote:
> Hi Prashanth and Jun,
>
> I checked out the latest 0.8 branch, and found that the
> PrimitiveApiTest hangs on every run. The last known good revision that
> I was tracking was 1239937. From svn, looks like the last few checkins
> were your patches -
>
>
> nnarkhed-ld:kafka-239-topic-metadata nnarkhed$ svn log -l 5
> ------------------------------------------------------------------------
> r1244650 | junrao | 2012-02-15 11:08:08 -0800 (Wed, 15 Feb 2012) | 1 line
>
> disable dup topic in consumer request; patched by Prashanth Menon;
> reviewed by Jun Rao; KAFKA-240
> ------------------------------------------------------------------------
> r1243407 | junrao | 2012-02-12 19:58:37 -0800 (Sun, 12 Feb 2012) | 1 line
>
> new consumer request format; patched by Prashanth Menon; reviewed by
> Jun Rao and Jay Kreps; KAFKA-240
> ------------------------------------------------------------------------
> r1241754 | junrao | 2012-02-07 18:59:54 -0800 (Tue, 07 Feb 2012) | 1 line
>
> refactor the async producer; patched by Jun Rao; reviewed by Neha
> Narkhede; KAFKA-253
> ------------------------------------------------------------------------
> r1239937 | nehanarkhede | 2012-02-02 15:40:39 -0800 (Thu, 02 Feb 2012) | 1 line
>
> Merging commits 1230840:1239902 from trunk
> ------------------------------------------------------------------------
> r1235492 | nehanarkhede | 2012-01-24 12:54:11 -0800 (Tue, 24 Jan 2012) | 1 line
>
>
> Would you mind taking a look and stabilizing the branch, this is
> blocking the patch on kafka-239.
>
> Thanks,
> Neha