You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/08/10 03:43:52 UTC
[GitHub] incubator-beam pull request #807: [BEAM-498] Remove WindowingInternals suppo...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/807
[BEAM-498] Remove WindowingInternals support from DoFnReflector
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
The test themselves are replaced by mostly-hidden placeholders, to ensure that our code for handling generic parameters remains in place until new context parameters that use generics are added back.
R: @bjchambers since `ExtraContextFactory` is a public interface, currently the hiding is a bit hackish. Probably we can and should refactor it a bit anyhow, but how about this for short term prevention of abuse?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam DoFn-WindowingInternals
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/807.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #807
----
commit 9c9bb05d2f9545762b4e2a58d0ed2481a6573448
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-08-10T03:42:04Z
Remove WindowingInternals support from DoFnReflector
The test themselves are replaced by mostly-hidden placeholders, to
ensure that our code for handling generic parameters remains in place
until new context parameters that use generics are added back.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #807: [BEAM-498] Remove WindowingInternals suppo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/807
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---