You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2018/08/09 22:35:39 UTC
Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use
reflection to instantiate embedded HMS instance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/
-----------------------------------------------------------
(Updated Aug. 9, 2018, 10:35 p.m.)
Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar.
Changes
-------
Fixed HiveMetaStoreClientPreCatalog to use the new signature for newRetryingHMSHandler
Bugs: HIVE-20194
https://issues.apache.org/jira/browse/HIVE-20194
Repository: hive-git
Description
-------
HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance
Diffs (updated)
-----
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a53d4be03d695bf2176436967026757391531bc9
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 91c86a749c7afb06737c850e57f60820710c51f5
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 34055d2d4d39dc63d505a5ef95d190aa80a49d14
Diff: https://reviews.apache.org/r/67954/diff/5/
Changes: https://reviews.apache.org/r/67954/diff/4-5/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use
reflection to instantiate embedded HMS instance
Posted by Alan Gates <ga...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/#review207091
-----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
Lines 110 (patched)
<https://reviews.apache.org/r/67954/#comment290320>
You define these two values both here and in HiveMetaStoreClientPreCatalog. Wouldn't it make more sense to define them once in a shared location (like IMetaStoreClient maybe)?
- Alan Gates
On Aug. 9, 2018, 10:35 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67954/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2018, 10:35 p.m.)
>
>
> Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar.
>
>
> Bugs: HIVE-20194
> https://issues.apache.org/jira/browse/HIVE-20194
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a53d4be03d695bf2176436967026757391531bc9
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 91c86a749c7afb06737c850e57f60820710c51f5
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 34055d2d4d39dc63d505a5ef95d190aa80a49d14
>
>
> Diff: https://reviews.apache.org/r/67954/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use
reflection to instantiate embedded HMS instance
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/
-----------------------------------------------------------
(Updated Aug. 10, 2018, 9:31 p.m.)
Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar.
Changes
-------
Addressed comment from Alan Gates.
Bugs: HIVE-20194
https://issues.apache.org/jira/browse/HIVE-20194
Repository: hive-git
Description
-------
HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance
Diffs (updated)
-----
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a53d4be03d695bf2176436967026757391531bc9
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 91c86a749c7afb06737c850e57f60820710c51f5
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 34055d2d4d39dc63d505a5ef95d190aa80a49d14
Diff: https://reviews.apache.org/r/67954/diff/6/
Changes: https://reviews.apache.org/r/67954/diff/5-6/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use
reflection to instantiate embedded HMS instance
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/#review207090
-----------------------------------------------------------
Ship it!
Ship It!
- Vihang Karajgaonkar
On Aug. 9, 2018, 10:35 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67954/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2018, 10:35 p.m.)
>
>
> Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar.
>
>
> Bugs: HIVE-20194
> https://issues.apache.org/jira/browse/HIVE-20194
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a53d4be03d695bf2176436967026757391531bc9
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 91c86a749c7afb06737c850e57f60820710c51f5
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 34055d2d4d39dc63d505a5ef95d190aa80a49d14
>
>
> Diff: https://reviews.apache.org/r/67954/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>