[GitHub] [calcite] jcamachor commented on a change in pull request #2094: [CALCITE-3409] Add an interface in RelOptMaterializations…

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #2094:
URL: https://github.com/apache/calcite/pull/2094#discussion_r714094628



##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java
##########
@@ -214,7 +232,11 @@
     hepPlanner.setRoot(root);
     root = hepPlanner.findBestExp();
 
-    return new SubstitutionVisitor(target, root).go(materialization.tableRel);
+    return new SubstitutionVisitor(target, root, ImmutableList.
+        <SubstitutionVisitor.UnifyRule>builder()
+        .addAll(materializationRules)
+        .addAll(SubstitutionVisitor.DEFAULT_RULES)

Review comment:
       This seems to be a new change. As @wojustme pointed out, this seems to prevent anyone from using their own materialization rules without including the default ones. Can we remove this line? Same result should be obtained by passing the default rules as part of the externally injected ones.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org