[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4270: skip the inverted index generation

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4270: skip the inverted index generation
URL: https://github.com/apache/incubator-pinot/pull/4270#discussion_r289969621
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
 ##########
 @@ -158,8 +158,12 @@ public void init(SegmentGeneratorConfig segmentCreationSpec, SegmentIndexCreatio
         }
 
         // Initialize inverted index creator
+        // Do not created inverted index if sorted, clean up invertedIndexColumns
         if (invertedIndexColumns.contains(columnName)) {
 
 Review comment:
   Change this line to `if (invertedIndexColumns.contains(columnName) && !indexCreationInfo.isSorted())` should be good. We don't need to clean up the invertedIndexColumns (it won't be populated outside even if you changed it).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org