You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/30 16:17:37 UTC

[GitHub] [maven-surefire] SimonBaars opened a new pull request, #575: [SUREFIRE-1654] Remove deprecated `forkMode` parameter

SimonBaars opened a new pull request, #575:
URL: https://github.com/apache/maven-surefire/pull/575

The `forkMode` parameter has been deprecated in Surefire 2.14, and with the upcoming 3.0 release, it's finally time to remove the parameter once and for all.

## Reviewer instructions
Removing the `forkMode` ended up being a quite comprehensive change. Throughout the refactoring/restructuring process, I ran the tests and integration tests often, to ensure equivalent behavior. I re-purposed most `forkMode` tests to test the `forkCount` parameter, removing a few that were per definition redundant.

Each commit should address a "sub-issue" I had to tackle to remove the `forkMode`. If the entire diff looks daunting, I can recommend reviewing commit-by-commit. Each commit should be a version that compiles on its own.

Here are a few more pointers for reviewing:
- Read [this article](https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html#migrating-the-deprecated-forkmode-parameter-to-forkcount-and-reu) about migrating `forkMode` to `forkCount`.
- Start with the first commit, where I remove the most important traces of the `forkMode` parameter, before moving on to the entire diff.
- I removed the migration guide from the docs. Is that okay or would we like to keep it up for now?
- I left some convenience methods for the different fork modes in the SurefireLauncher, let me know if you'd like me to unfold that.
- I avoided the term "fork mode" as much as possible, but still left some traces where it made sense.

## What's next?
While working on this, I noticed a few codebase styling issues that I'd like to refactor. To keep the diff of this PR sensible, I decided it would be better to open a separate PR for that. So you can expect another PR incoming 😉

## Checklist
Following this checklist to help us incorporate your
contribution quickly and easily:

- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE-1654) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).

If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.

## License
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.

- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)

- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org