You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/08 18:51:39 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2497: crypto/random_pool.c: fix getrandom() when thread calling it gets can…

xiaoxiang781216 commented on pull request #2497:
URL: https://github.com/apache/incubator-nuttx/pull/2497#issuecomment-740843598


   Please fix the low entropy case too:
   https://github.com/apache/incubator-nuttx/pull/2497/files#diff-ee6b9d93e85a2c9b845acc6c4fdcef1c9cca9ee4166cadd7b15f889f221065e7L330
   But, anyway this PR doesn't resolve the real problem, we should follow FreeBSD and Linux prototype:
   https://man7.org/linux/man-pages/man2/getrandom.2.html
   https://www.freebsd.org/cgi/man.cgi?query=getrandom&sektion=2&manpath=freebsd-release-ports
   If we allow the contributor to modify the public function prototype, NuttX will lose the compability in the long run.
   If you insist to not change getrandom prototype to confirm the standard, I will create a patch remove it from the code base.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org