You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2016/12/10 03:59:38 UTC
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5461
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
[spark] KUDU-1631 push down StringStartsWith filters
This adds support for pushing down StringStartsWith filters to
Kudu. It converts the prefix query into a range query.
Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
2 files changed, 72 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/5461/1
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5461/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala:
Line 192: p.reverse.dropWhile(_ == Char.MaxValue).reverse match {
> ??
This was supposed to be a thumbs-up emoji but it doesn't show up correctly after being posted :(
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
Patch Set 1:
I wonder if we should add a method for this in the client API itself -- it seems error prone to make people come up with the "prefix -> range" conversion algorithm
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5461/2/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala:
Line 346: val chars = List('a', 'b', '\u4e55', Char.MaxValue)
Would be good to add "\0" (null) character to this set.
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
[spark] KUDU-1631 push down StringStartsWith filters
This adds support for pushing down StringStartsWith filters to
Kudu. It converts the prefix query into a range query.
Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Reviewed-on: http://gerrit.cloudera.org:8080/5461
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
2 files changed, 70 insertions(+), 5 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5461
to look at the new patch set (#2).
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
[spark] KUDU-1631 push down StringStartsWith filters
This adds support for pushing down StringStartsWith filters to
Kudu. It converts the prefix query into a range query.
Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
2 files changed, 70 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/5461/2
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5461/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala:
Line 22: import com.google.common.annotations.VisibleForTesting
This isn't being used.
Line 192: p.reverse.dropWhile(_ == Char.MaxValue).reverse match {
We discussed on Slack how this method can do anywhere between 2 and 6 or 7 copies of the original string depending on the mood of Scalac, but I don't know of a better way or more clear way to write it to optimize for fewer copies. The code as it is now is very idiomatic, so until it becomes an issue I think it's fine as is.
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5461/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala:
Line 22: import com.google.common.annotations.VisibleForTesting
> This isn't being used.
Done
Line 192: p.reverse.dropWhile(_ == Char.MaxValue).reverse match {
> We discussed on Slack how this method can do anywhere between 2 and 6 or 7
??
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
Patch Set 1:
> add a method for this in the client API itself
Filed a feature request at https://issues.apache.org/jira/browse/KUDU-1804
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5461
to look at the new patch set (#3).
Change subject: [spark] KUDU-1631 push down StringStartsWith filters
......................................................................
[spark] KUDU-1631 push down StringStartsWith filters
This adds support for pushing down StringStartsWith filters to
Kudu. It converts the prefix query into a range query.
Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
2 files changed, 70 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/5461/3
--
To view, visit http://gerrit.cloudera.org:8080/5461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>