You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "harinreddy (Code Review)" <ge...@cloudera.org> on 2022/09/16 18:09:25 UTC
[kudu-CR] Skips -msse4.2 compiler flag for arch: ppc64le
harinreddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19000
Change subject: Skips -msse4.2 compiler flag for arch: ppc64le
......................................................................
Skips -msse4.2 compiler flag for arch: ppc64le
Files affected kudu/CMakeLists.txt
sse4.2 is x86_64 specific compiler flag. Since compilers for powerpc
architecture (ppc64le) do not support this flag, this patch skips
this flag when ARCH_NAME=ppc64le is detected.
Changes to be committed:
modified: CMakeLists.txt
Change-Id: Ic5e87857796e97fffc85c527045b7e4fa914e896
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/19000/1
--
To view, visit http://gerrit.cloudera.org:8080/19000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5e87857796e97fffc85c527045b7e4fa914e896
Gerrit-Change-Number: 19000
Gerrit-PatchSet: 1
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
[kudu-CR] Skips -msse4.2 compiler flag for arch: ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19000 )
Change subject: Skips -msse4.2 compiler flag for arch: ppc64le
......................................................................
Patch Set 2: Code-Review+2
Thank you for the contribution!
--
To view, visit http://gerrit.cloudera.org:8080/19000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e87857796e97fffc85c527045b7e4fa914e896
Gerrit-Change-Number: 19000
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Jan 2023 19:03:41 +0000
Gerrit-HasComments: No
[kudu-CR] Skips -msse4.2 compiler flag for arch: ppc64le
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19000 )
Change subject: Skips -msse4.2 compiler flag for arch: ppc64le
......................................................................
Skips -msse4.2 compiler flag for arch: ppc64le
Files affected kudu/CMakeLists.txt
sse4.2 is x86_64 specific compiler flag. Since compilers for powerpc
architecture (ppc64le) do not support this flag, this patch skips
this flag when ARCH_NAME=ppc64le is detected.
Changes to be committed:
modified: CMakeLists.txt
Change-Id: Ic5e87857796e97fffc85c527045b7e4fa914e896
Reviewed-on: http://gerrit.cloudera.org:8080/19000
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5e87857796e97fffc85c527045b7e4fa914e896
Gerrit-Change-Number: 19000
Gerrit-PatchSet: 3
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)