You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/07/07 11:13:13 UTC
[GitHub] [beam] damccorm opened a new pull request, #27388: Revert "Replace StorageV1 client with GCS client"
damccorm opened a new pull request, #27388:
URL: https://github.com/apache/beam/pull/27388
Reverts apache/beam#25965 because I think this may have broken Python PostCommits (https://ci-beam.apache.org/job/beam_PostCommit_Python311/358/ is the first failing run)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #27388: Revert "Replace StorageV1 client with GCS client"
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #27388:
URL: https://github.com/apache/beam/pull/27388#issuecomment-1625444343
R: @BjornPrime @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #27388: Revert "Replace StorageV1 client with GCS client"
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #27388:
URL: https://github.com/apache/beam/pull/27388#issuecomment-1625287783
Run Python_Runners PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #27388: Revert "Replace StorageV1 client with GCS client"
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #27388:
URL: https://github.com/apache/beam/pull/27388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27388: Revert "Replace StorageV1 client with GCS client"
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27388:
URL: https://github.com/apache/beam/pull/27388#issuecomment-1625445949
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #27388: Revert "Replace StorageV1 client with GCS client"
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #27388:
URL: https://github.com/apache/beam/pull/27388#issuecomment-1625255651
Run Python 3.10 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27388: Revert "Replace StorageV1 client with GCS client"
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27388:
URL: https://github.com/apache/beam/pull/27388#issuecomment-1625278719
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27388](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f35d836) into [master](https://app.codecov.io/gh/apache/beam/commit/f19c384af1f1952df60162ee70ce0f1cb3621a7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f19c384) will **increase** coverage by `0.26%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #27388 +/- ##
==========================================
+ Coverage 71.05% 71.32% +0.26%
==========================================
Files 858 862 +4
Lines 104105 105202 +1097
==========================================
+ Hits 73975 75032 +1057
- Misses 28581 28621 +40
Partials 1549 1549
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `80.52% <75.00%> (+0.25%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/apache\_beam/examples/complete/game/user\_score.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvZ2FtZS91c2VyX3Njb3JlLnB5) | `62.79% <ø> (ø)` | |
| [sdks/python/apache\_beam/internal/gcp/auth.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL2F1dGgucHk=) | `79.16% <ø> (+0.78%)` | :arrow_up: |
| [...cp/internal/clients/storage/storage\_v1\_messages.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvc3RvcmFnZS9zdG9yYWdlX3YxX21lc3NhZ2VzLnB5) | `100.00% <ø> (ø)` | |
| [sdks/python/setup.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vc2V0dXAucHk=) | `0.00% <ø> (ø)` | |
| [...\_beam/runners/portability/sdk\_container\_builder.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=) | `37.93% <8.33%> (+1.03%)` | :arrow_up: |
| [...apache\_beam/runners/dataflow/internal/apiclient.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | `77.02% <18.18%> (-0.15%)` | :arrow_down: |
| [.../gcp/internal/clients/storage/storage\_v1\_client.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvc3RvcmFnZS9zdG9yYWdlX3YxX2NsaWVudC5weQ==) | `65.26% <65.26%> (ø)` | |
| [sdks/python/apache\_beam/io/gcp/gcsio\_overrides.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2lvX292ZXJyaWRlcy5weQ==) | `70.00% <70.00%> (ø)` | |
| [...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvc3RvcmFnZS9fX2luaXRfXy5weQ==) | `77.77% <77.77%> (ø)` | |
| [sdks/python/apache\_beam/io/gcp/gcsio.py](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2lvLnB5) | `92.28% <89.87%> (+25.61%)` | :arrow_up: |
| ... and [2 more](https://app.codecov.io/gh/apache/beam/pull/27388?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27388/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org