[jira] [Closed] (LANG-1142) StringUtils#capitalize: Javadoc says toTitleCase; code uses toUpperCase

["Henri Yandell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LANG-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-1142.
-------------------------------
       Resolution: Fixed
    Fix Version/s: 3.5

$ git commit
[master 421db38] Switched capitalize back to using toTitleCase. Added a test for this using the 'Lj' letter. LANG-1142
 2 files changed, 4 insertions(+), 1 deletion(-)

> StringUtils#capitalize: Javadoc says toTitleCase; code uses toUpperCase
> -----------------------------------------------------------------------
>
>                 Key: LANG-1142
>                 URL: https://issues.apache.org/jira/browse/LANG-1142
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>    Affects Versions: 3.4
>            Reporter: Sebb
>             Fix For: 3.5
>
>
> The capitalize Javadoc says the code uses  Character#toTitleCase, however the code actually uses Character#toUpperCase.
> Generally these produce the same result, but some charsets may have different characters for upper and title case - see for example the Javadoc [1] for Character#isTitleCase.
> The way I read this, the character that looks like "lj" is lower-case, "LJ" is upper case and "Lj" is title case - i.e. not the same.
> The question here is: should the code be corrected to use TitleCase or should the Javadoc be corrected to use UpperCase?
> [1] http://docs.oracle.com/javase/7/docs/api/java/lang/Character.html#isTitleCase%28char%29



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)